Add VLAN ID to hardware interface spec #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version was very old, only a release candidate, and was failing to run the `make check-generated` and `make generated` targets on linux. The changes to the generated files are all formatting based. No actual or functional changes were made. Signed-off-by: Jacob Weinstock <[email protected]>
This will help in enabling trunk vlan support in across the Tinkerbell stack. See proposal 0030 in https://github.com/tinkerbell/proposals Signed-off-by: Jacob Weinstock <[email protected]>
The version was a bit out dated and was having issues with Go 1.19. Updated and fixed all linting errors. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
Signed-off-by: Jacob Weinstock <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #642 +/- ##
==========================================
- Coverage 45.07% 45.06% -0.01%
==========================================
Files 62 62
Lines 3554 3557 +3
==========================================
+ Hits 1602 1603 +1
- Misses 1870 1872 +2
Partials 82 82
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
vlan
branch
from
a8aee29 to
6d43994
Compare
Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
added
the
kind/feature
This allows a default value of "" to be used instead of 0 when the VLANID type is int. As 0 is a valid vlan id, we dont want that to be the default as it would make it impossible for the VLANID to be "unset" and therefore not added to DHCP requests, etc. Signed-off-by: Jacob Weinstock <[email protected]>
chrisdoherty4
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds vlan id to interfaces in the hardware spec.
FYI, hidden inside of all this generated code, linting, and dependency version updates is the reason for this PR. The small addition of vlan id to the hardware interface struct. Look here:
/pkg/apis/core/v1alpha1/hardware_types.go.Also, important to note that this PR updates the Go version from
1.17to1.18, this was required to get the make targets for generating code functioning properly for me.Why is this needed
Needed to enabled trunk port support across the stack. See proposal tinkerbell/proposals#60
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: