Skip to content

Commit

Permalink
[tink-worker] Fix use and defaulting of the max-retry flag (#322)
Browse files Browse the repository at this point in the history
## Description

Previously we were trying to fetch the wrong flag value when configuring retries for tink-worker, this PR fixes that.

## Why is this needed

## How Has This Been Tested?
I tested this in my Tilt/kind setup

## How are existing users impacted? What migration steps/scripts do we need?

Fixes issues with using the latest tink-worker for e2e testing/deployment.

It doesn't require any changes for users or require any additional migration.
  • Loading branch information
mergify[bot] authored Oct 8, 2020
2 parents 30f4302 + 0eeb688 commit 4606f1e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/tink-worker/cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func NewRootCommand(version string, logger log.Logger) *cobra.Command {
},
RunE: func(cmd *cobra.Command, args []string) error {
retryInterval, _ := cmd.Flags().GetDuration("retry-interval")
retries, _ := cmd.Flags().GetInt("retries")
retries, _ := cmd.Flags().GetInt("max-retry")
// TODO(displague) is log-level no longer useful?
// logLevel, _ := cmd.Flags().GetString("log-level")
workerID, _ := cmd.Flags().GetString("id")
Expand Down

0 comments on commit 4606f1e

Please sign in to comment.