Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tink-worker] Fix use and defaulting of the max-retry flag #322

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

detiber
Copy link
Contributor

@detiber detiber commented Oct 7, 2020

Description

Previously we were trying to fetch the wrong flag value when configuring retries for tink-worker, this PR fixes that.

Why is this needed

How Has This Been Tested?

I tested this in my Tilt/kind setup

How are existing users impacted? What migration steps/scripts do we need?

Fixes issues with using the latest tink-worker for e2e testing/deployment.

It doesn't require any changes for users or require any additional migration.

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@30f4302). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #322   +/-   ##
=========================================
  Coverage          ?   23.79%           
=========================================
  Files             ?       14           
  Lines             ?     1244           
  Branches          ?        0           
=========================================
  Hits              ?      296           
  Misses            ?      928           
  Partials          ?       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30f4302...0eeb688. Read the comment docs.

@detiber detiber requested a review from displague October 7, 2020 19:03
Copy link
Member

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This coincides with

rootCmd.Flags().Int("max-retry", defaultRetryCount, "Maximum number of retries to attempt (MAX_RETRY)")

@detiber detiber added the ready-to-merge Signal to Mergify to merge the PR. label Oct 8, 2020
@mergify mergify bot merged commit 4606f1e into tinkerbell:master Oct 8, 2020
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants