Merge pull request #729 from jacobweinstock/fix-ci

Add GOBIN for protoc binaries installs:
tinkerbell · May 13, 2023 · 861779b · 861779b
2 parents eef6545 + 810a039
commit 861779b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -240,5 +240,5 @@ yamllint: $(YAMLLINT_BIN)
 
 .PHONY: _protoc ## Install all required tools for use with this Makefile.
 _protoc:
-	$(GO) install $(PROTOC_GEN_GO)
-	$(GO) install $(PROTOC_GEN_GO_GRPC)
+	GOBIN=$${PWD}/bin $(GO) install $(PROTOC_GEN_GO)
+	GOBIN=$${PWD}/bin $(GO) install $(PROTOC_GEN_GO_GRPC)
diff --git a/shell.nix b/shell.nix
@@ -11,6 +11,8 @@ with pkgs;
 
 mkShell {
   buildInputs = [
+    git
+    gnumake
     jq
     nixfmt
     nodePackages.prettier
-Original file line number
+Diff line change
@@ Expand Up / @@ -11,6 +11,8 @@ with pkgs; @@
     mkShell {
       buildInputs = [
+        git
+        gnumake
         jq
         nixfmt
         nodePackages.prettier
@@ Expand Down @@