Add GOBIN for protoc binaries installs: #729
Conversation
This puts the protoc binaries in our `bin` directory so that they are available when we update the PATH at the top of the Makefile. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #729 +/- ##
=======================================
Coverage 55.54% 55.54%
=======================================
Files 26 26
Lines 1100 1100
=======================================
Hits 611 611
Misses 474 474
Partials 15 15 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
These deps were missing when running in docker and could be missing for users that have nix-shell already installed. Signed-off-by: Jacob Weinstock <[email protected]>
| GOBIN=$${PWD}/bin $(GO) install $(PROTOC_GEN_GO) |
There was a problem hiding this comment.
I don't think make generate-proto will find these binaries unless someone adds $PWD/bin so their path.
I'd be keen to stick them under out/bin or out/tools also. I intend on moving the binaries we build to out/bin at some point so we have easy clean up. This compliments the existing out stuff we have for linters and releasing.
There was a problem hiding this comment.
the makefile does add $PWD/bin to the PATH.
Line 4 in eef6545
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 861779b |
Description
This puts the protoc binaries in our
bindirectory so that they are available when we update the PATH at the top of the Makefile.Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: