Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove leftovers from merging hardware and targets #114

Closed
invidian opened this issue May 14, 2020 · 1 comment · Fixed by #137
Closed

Remove leftovers from merging hardware and targets #114

invidian opened this issue May 14, 2020 · 1 comment · Fixed by #137
Assignees
@parauliya

Comments

@invidian
Copy link
Contributor

There are still references to Target fields in the code, which should be removed/renamed after #88 got merged.

Example: https://github.com/tinkerbell/tink/blob/master/cli/tink/cmd/workflow/create.go#L45
@parauliya
Copy link
Contributor

Hi @invidian we knew these places and we are fixing it.

parauliya pushed a commit to infracloudio/tink that referenced this issue May 26, 2020
Fix issue tinkerbell#114: Remove the target reference from code
8d2e3e1
@parauliya parauliya linked a pull request May 27, 2020 that will close this issue
Fix issue #114: Remove the target reference from code #137
Merged
gauravgahlot pushed a commit that referenced this issue May 27, 2020
Fix issue #114: Remove the target reference from code
d9d6b63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parauliya parauliya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue #114: Remove the target reference from code infracloudio/tink
3 participants
@invidian @gauravgahlot @parauliya