-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge hardware and target. #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parauliya
added
kind/feature
Categorizes issue or PR as related to a new feature.
do-not-merge
Signal to Mergify to block merging of the PR.
labels
Apr 30, 2020
gauravgahlot
removed
the
do-not-merge
Signal to Mergify to block merging of the PR.
label
Apr 30, 2020
parauliya
force-pushed
the
remove_target
branch
from
April 30, 2020 12:02
b53f5a5
to
df59f0e
Compare
Now while creating a workflow you can directly provide hardware/devices mac addr. And now there is no need of targets.
Signed-off-by: Gaurav Gahlot <[email protected]>
Signed-off-by: Gaurav Gahlot <[email protected]>
Signed-off-by: Gaurav Gahlot <[email protected]>
parauliya
changed the title
[WIP] : Merged hardware and target.
Merged hardware and target.
May 5, 2020
gauravgahlot
suggested changes
May 6, 2020
gauravgahlot
reviewed
May 6, 2020
mmlb
reviewed
May 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
parauliya
requested review from
gauravgahlot
and removed request for
nathangoulding
May 9, 2020 09:25
gauravgahlot
approved these changes
May 9, 2020
This was referenced May 13, 2020
Does this mean that the target creation is no longer required? |
mmlb
pushed a commit
to mmlb/tinkerbell-tink
that referenced
this pull request
May 21, 2020
* Merged hardware and target. Now while creating a workflow you can directly provide hardware/devices mac addr. And now there is no need of targets. * using hello-world as the first example Signed-off-by: Gaurav Gahlot <[email protected]> * fixes Signed-off-by: Gaurav Gahlot <[email protected]> * moved comments out of data JSON Signed-off-by: Gaurav Gahlot <[email protected]> * Changed the way of writing template and creating workflow * Updating the docs with current implementation * Incorporated some minor review comments Co-authored-by: Gaurav Gahlot <[email protected]>
parauliya
added a commit
to infracloudio/tink
that referenced
this pull request
May 22, 2020
* Merged hardware and target. Now while creating a workflow you can directly provide hardware/devices mac addr. And now there is no need of targets. * using hello-world as the first example Signed-off-by: Gaurav Gahlot <[email protected]> * fixes Signed-off-by: Gaurav Gahlot <[email protected]> * moved comments out of data JSON Signed-off-by: Gaurav Gahlot <[email protected]> * Changed the way of writing template and creating workflow * Updating the docs with current implementation * Incorporated some minor review comments Co-authored-by: Gaurav Gahlot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now while creating a workflow you can directly provide hardware/devices mac addr.
And now there is no need of targets. This approach will support both single and multiple workers as well:
Current
template
look like this forworker
field: ( Has theTarget
reference )worker: "{{index .Targets "machine1" "mac_addr"}}"
After this PR the
template
will look like this forworker
field: (Target
reference not required)worker: {{.device_1}}
Right Now the
workflow create
command is as follows for single and multiple worker: ( Has theTarget
reference )tink workflow create -t <temp-id> -r <target-id>
After this PR the
workflow create
command it will look like: (Target
reference not required )For single worker
tink workflow create -t <template_id> -r '{ "device_1": "mac/IP/Id" }'
For Multiple worker you can just increase the key value pair in the workflow create command:
tink workflow create -t <template_id> -r '{ "device_1": "mac/IP", "device_2": "mac/IP"}'
Note: In the above case user can replace the keys device_1/device_2 with any name which should contain only
letters, numbers and Underscore
and should be in sync with template.