"tink workflow state" does not return error when workflow UUID can't be found

[invidian]

Expected Behaviour

Running tink workflow state $(uuidgen) should always return error.

Current Behaviour

Running the command above exits with 0:

0 ✓ (28.1ms) 11:23:44 invidian@dellxps15mateusz ~/repos/kinvolk/tink/cmd/tink-cli (master)$ ./tink-cli workflow state $(uuidgen)
+----------------------+---------------+
| FIELD NAME           | VALUES        |
+----------------------+---------------+
| Workflow ID          |               |
| Workflow Progress    | 0%            |
| Current Task         |               |
| Current Action       |               |
| Current Worker       |               |
| Current Action State | STATE_PENDING |
+----------------------+---------------+
0 ✓ (54.4ms) 11:23:48 invidian@dellxps15mateusz ~/repos/kinvolk/tink/cmd/tink-cli (master)$

Possible Solution

Add validation.

Steps to Reproduce (for bugs)

1. tink workflow state $(uuidgen)

Context

Tinkerbell version: 9c52cca

[gianarb]

@thebsdbox I removed the bug label because looking at the code, it is written with that behavior in mind. I don't have enough context to know why, but first, we have to figure out if this is a feature or a bug

[splaspood]

In my opinion this is most certainly a bug. A deleted workflow still has state in the database that could be returned here. If the intention is to not return data for deleted workflows, then the state command should return an error when looking up a 'nonexistent' workflow.

[gianarb]

I think we should leave it there for visibility and troubleshooting purpose at least for some time. For the same reason kubernetes doesn't delete resource straight away. But I am not sure how it works today

…

On Wed, 24 Feb 2021, 19:32 James W. Brinkerhoff IV, < ***@***.***> wrote: In my opinion this is most certainly a bug. A deleted workflow still has state in the database that could be returned here. If the intention is to not return data for deleted workflows, then the state command should return an error when looking up a 'nonexistent' workflow. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#381 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMOAO7PFV5ZLCPXTZHLBB3TAVA2BANCNFSM4UUZXHKA> .