Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #381: 'tink workflow state' command returns an error if workflow does not exist #447

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

parauliya
Copy link
Contributor

@parauliya parauliya commented Mar 4, 2021

Signed-off-by: parauliya [email protected]

Description

Now tink workflow state <wfid> command will return an error if the workflow with id wfid does not exist.

Why is this needed

Fixes: #381

How Has This Been Tested?

Tested with Vagrant setup.

How are existing users impacted? What migration steps/scripts do we need?

No Impact on existing users.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@parauliya parauliya requested a review from gauravgahlot March 4, 2021 11:00
@parauliya parauliya self-assigned this Mar 4, 2021
@parauliya parauliya added the kind/bug Categorizes issue or PR as related to a bug. label Mar 4, 2021
…if workflow does not exist

Signed-off-by: parauliya <[email protected]>
@parauliya parauliya requested a review from gianarb March 4, 2021 11:02
@parauliya parauliya marked this pull request as draft March 4, 2021 11:02
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #447 (71b2662) into master (5e1f0fd) will increase coverage by 0.67%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
+ Coverage   35.14%   35.82%   +0.67%     
==========================================
  Files          47       47              
  Lines        2888     2892       +4     
==========================================
+ Hits         1015     1036      +21     
+ Misses       1781     1763      -18     
- Partials       92       93       +1     
Impacted Files Coverage Δ
db/workflow.go 29.09% <0.00%> (-0.12%) ⬇️
grpc-server/workflow.go 39.78% <100.00%> (+10.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e1f0fd...e7fdb8d. Read the comment docs.

@parauliya
Copy link
Contributor Author

parauliya commented Mar 4, 2021

This PR will fix the issue #381 but there are few more similar issue which I found will be pushed in the same PR and then this will be marked as Ready for Review.

@parauliya parauliya marked this pull request as ready for review March 5, 2021 08:55
@gianarb gianarb added the needs-tests Needs supporting unit tests label Mar 8, 2021
Signed-off-by: parauliya <[email protected]>
@parauliya parauliya removed the needs-tests Needs supporting unit tests label Mar 8, 2021
@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Mar 8, 2021
@parauliya parauliya merged commit c4e5d39 into tinkerbell:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"tink workflow state" does not return error when workflow UUID can't be found
2 participants