Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the event system #464

Closed
gianarb opened this issue Mar 23, 2021 · 0 comments · Fixed by #468
Closed

Remove the event system #464

gianarb opened this issue Mar 23, 2021 · 0 comments · Fixed by #468
Assignees
@gauravgahlot
Labels
breaking-change Denotes a PR that introduces potentially breaking changes that require user action. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@gianarb
Copy link
Contributor

gianarb commented Mar 23, 2021 •
edited
Loading

Expected Behaviour

An event system that does not hurts!

Current Behaviour

The event system is in place relays on triggers. It causes many problems because of its 8k characters limitation #413 . Equinix Metal internally dropped it and CAPT (@detiber ) is suffering from this limitation. Not many people are using it, so we are still on time. Outside extensibility is not a priority and we want to get it right.

Possible Solution

  • Remove it
  • Design a better data model

We decided to remove it because extensibility is not a priority

How to migrate

Right now we need more time to implement the event system in a more solid and reliable way. Tinkerbell won't offer an alternative approach
@gianarb gianarb added the breaking-change Denotes a PR that introduces potentially breaking changes that require user action. label Mar 23, 2021
@gauravgahlot gauravgahlot self-assigned this Mar 25, 2021
@gauravgahlot gauravgahlot mentioned this issue Mar 26, 2021
Merged
3 tasks
@gauravgahlot gauravgahlot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 26, 2021
@mergify mergify bot closed this as completed in #468 Apr 8, 2021
mergify bot added a commit that referenced this issue Apr 8, 2021
@mergify
Drop the events system (#468)
a7ffd35 
## Description

The PR removes all the code and DB changes related to the events system.

## Why is this needed

Fixes: #464 

## How Has This Been Tested?

- Existing unit tests
- Manual tests

## How are existing users impacted? What migration steps/scripts do we need?

This is a breaking change, especially for any users currently using events.
If your tool is not using tink events the migration should be smooth.

## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
This was referenced Apr 19, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gauravgahlot gauravgahlot

Labels
breaking-change Denotes a PR that introduces potentially breaking changes that require user action. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop the events system gauravgahlot/tink
2 participants
@gianarb @gauravgahlot