Drop the events system #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravgahlot
added
the
priority/critical-urgent
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
==========================================
- Coverage 32.32% 32.09% -0.23%
==========================================
Files 50 44 -6
Lines 3276 3103 -173
==========================================
- Hits 1059 996 -63
+ Misses 2123 2017 -106
+ Partials 94 90 -4
Continue to review full report at Codecov.
|
gauravgahlot
force-pushed
the
drop-event-system
branch
from
ea5ece4 to
b406c0f
Compare
gianarb
added
breaking-change
|
@detiber do you mind to have a look at this please? |
gianarb
added
ci-check/vagrant-setup
gauravgahlot
added
ci-check/vagrant-setup
gauravgahlot
force-pushed
the
drop-event-system
branch
from
19cba21 to
01c09e6
Compare
gianarb
added
ci-check/vagrant-setup
gauravgahlot
force-pushed
the
drop-event-system
branch
from
01c09e6 to
7a9229c
Compare
Signed-off-by: Gaurav Gahlot <[email protected]>
Signed-off-by: Gaurav Gahlot <[email protected]>
Signed-off-by: Gaurav Gahlot <[email protected]>
gauravgahlot
force-pushed
the
drop-event-system
branch
from
7a9229c to
ce914db
Compare
gauravgahlot
removed
the
ci-check/vagrant-setup
|
@gauravgahlot So once this PR is merged, the 8000 bytes limit from the triggers will be solved right? |
@moadqassem After this PR is merged there will be no event triggers at all. 😄 |
gianarb
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR removes all the code and DB changes related to the events system.
Why is this needed
Fixes: #464
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
This is a breaking change, especially for any users currently using events.
If your tool is not using tink events the migration should be smooth.
Checklist:
I have: