Refactoring db package for unit tests #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Gahlot <[email protected]>
gauravgahlot
added
kind/feature
Signed-off-by: Gaurav Gahlot <[email protected]>
Signed-off-by: Gaurav Gahlot <[email protected]>
Signed-off-by: Gaurav Gahlot <[email protected]>
Signed-off-by: Gaurav Gahlot <[email protected]>
gauravgahlot
force-pushed
the
server-tests
branch
from
0b37807 to
b27f6a4
Compare
gauravgahlot
removed
the
do-not-merge
gauravgahlot
force-pushed
the
server-tests
branch
from
b27f6a4 to
fac8852
Compare
gauravgahlot
changed the title
Cbkhare
suggested changes
Aug 11, 2020
Signed-off-by: Gaurav Gahlot <[email protected]>
gauravgahlot
force-pushed
the
server-tests
branch
from
653d178 to
6d9a03d
Compare
Cbkhare
suggested changes
Aug 11, 2020
grpc-server/tinkerbell.go
Outdated
| if len(req.GetActionName()) == 0 { | ||
| return nil, status.Errorf(codes.InvalidArgument, "action_name is invalid") | ||
| } | ||
| fmt.Printf("Received action status: %s\n", req) |
There was a problem hiding this comment.
Instead of fmt we should use log.
grpc-server/tinkerbell.go
Outdated
| fmt.Printf("Received action status: %s\n", req) | ||
| wfContext, err := s.db.GetWorkflowContexts(context, wfID) | ||
| if err != nil { | ||
| return nil, status.Errorf(codes.InvalidArgument, "workflow context not found for workflow %s", wfID) |
There was a problem hiding this comment.
this error statement seems to be valid with my above comment on same point. May be we can refine the statement and update it here as well.
grpc-server/tinkerbell.go
Outdated
| return true | ||
| } | ||
| } | ||
| } else { |
There was a problem hiding this comment.
not necessary but we can combine this else --> else if
Signed-off-by: Gaurav Gahlot <[email protected]>
parauliya
suggested changes
Aug 11, 2020
grpc-server/grpc_server.go
Outdated
| @@ -51,9 +50,9 @@ func SetupGRPC(ctx context.Context, log log.Logger, facility string, errCh chan< | |||
| } | |||
| logger = log | |||
| metrics.SetupMetrics(facility, logger) | |||
| db := db.ConnectDB(logger) | |||
| instance := db.Connect(logger) | |||
There was a problem hiding this comment.
I think the variable name should be changed since it is of type TinkDB which already has a field name instance which is a bit confusing.
Signed-off-by: Gaurav Gahlot <[email protected]>
gauravgahlot
force-pushed
the
server-tests
branch
from
08a671a to
d364cfa
Compare
Cbkhare
approved these changes
Aug 12, 2020
gianarb
reviewed
Aug 17, 2020
3 tasks
mergify bot
added a commit
that referenced
this pull request
Aug 19, 2020
## Description The PR restructures mocking based on the suggestion by @gianarb in this [thread](#247 (comment)). ## Why is this needed To write more flexible and|or reusable mocks. ## How Has This Been Tested? The changes include unit tests only. ## Coverage ``` ➜ go test -coverprofile coverage.out ➜ go tool cover -func coverage.out | grep tinkerbell.go github.com/tinkerbell/tink/grpc-server/tinkerbell.go:29: GetWorkflowContexts 0.0% github.com/tinkerbell/tink/grpc-server/tinkerbell.go:49: GetWorkflowContextList 100.0% github.com/tinkerbell/tink/grpc-server/tinkerbell.go:72: GetWorkflowActions 100.0% github.com/tinkerbell/tink/grpc-server/tinkerbell.go:81: ReportActionStatus 100.0% github.com/tinkerbell/tink/grpc-server/tinkerbell.go:138: UpdateWorkflowData 100.0% github.com/tinkerbell/tink/grpc-server/tinkerbell.go:155: GetWorkflowData 100.0% github.com/tinkerbell/tink/grpc-server/tinkerbell.go:168: GetWorkflowMetadata 100.0% github.com/tinkerbell/tink/grpc-server/tinkerbell.go:177: GetWorkflowDataVersion 100.0% github.com/tinkerbell/tink/grpc-server/tinkerbell.go:185: getWorkflowsForWorker 100.0% github.com/tinkerbell/tink/grpc-server/tinkerbell.go:196: getWorkflowActions 100.0% github.com/tinkerbell/tink/grpc-server/tinkerbell.go:206: isApplicableToSend 100.0% github.com/tinkerbell/tink/grpc-server/tinkerbell.go:233: isLastAction 100.0% ``` ## How are existing users impacted? What migration steps/scripts do we need? No impact. ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [x] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes include:
dbpackagedatabaseinterfaceWhy is this needed
For mocking database calls to write unit tests for gRPC server.
How are existing users impacted? What migration steps/scripts do we need?
No impact.
How Has This Been Tested?
I have tested the changes by executing an end-to-end workflow.