-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisiting tests to have reusable mocks #256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yep! That's the right direciton!! Thank you for doing it @gauravgahlot |
2 tasks
gauravgahlot
added
do-not-merge
Signal to Mergify to block merging of the PR.
added-tests
and removed
do-not-merge
Signal to Mergify to block merging of the PR.
labels
Aug 18, 2020
gauravgahlot
force-pushed
the
revisiting-tests
branch
from
August 19, 2020 12:46
4f0b59c
to
2ebc492
Compare
gauravgahlot
added
size/L
estimate of the amount of work to address the issue
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
labels
Aug 19, 2020
Can you squash your commits please? |
gauravgahlot
force-pushed
the
revisiting-tests
branch
3 times, most recently
from
August 19, 2020 14:10
eb7d402
to
af4f210
Compare
Signed-off-by: Gaurav Gahlot <[email protected]>
Signed-off-by: Gaurav Gahlot <[email protected]>
gauravgahlot
force-pushed
the
revisiting-tests
branch
from
August 19, 2020 14:26
3be20eb
to
b2bb462
Compare
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
+ Coverage 10.90% 12.36% +1.45%
==========================================
Files 7 7
Lines 1165 1165
==========================================
+ Hits 127 144 +17
+ Misses 1019 1010 -9
+ Partials 19 11 -8
Continue to review full report at Codecov.
|
gianarb
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
size/L
estimate of the amount of work to address the issue
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR restructures mocking based on the suggestion by @gianarb in this thread.
Why is this needed
To write more flexible and|or reusable mocks.
How Has This Been Tested?
The changes include unit tests only.
Coverage
How are existing users impacted? What migration steps/scripts do we need?
No impact.
Checklist:
I have: