Fix concurrent workflow create bug by unique index #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
=======================================
Coverage 23.79% 23.79%
=======================================
Files 14 14
Lines 1244 1244
=======================================
Hits 296 296
Misses 928 928
Partials 20 20 Continue to review full report at Codecov.
|
kqdeng
suggested changes
Oct 22, 2020
mmlb
suggested changes
Oct 22, 2020
ryli17
force-pushed
the
master
branch
2 times, most recently
from
6a401d4 to
8274ad6
Compare
|
squashed the commits. |
gianarb
previously approved these changes
Oct 23, 2020
mmlb
suggested changes
Oct 23, 2020
ryli17
force-pushed
the
master
branch
2 times, most recently
from
639fb5e to
1e9fc80
Compare
ryli17
changed the title
Signed-off-by: Ryan Li <[email protected]>
mmlb
approved these changes
Oct 23, 2020
kqdeng
approved these changes
Oct 23, 2020
This was referenced Oct 23, 2020
mergify bot
added a commit
that referenced
this pull request
Oct 26, 2020
## Description After PR #346 merged, raise back isolation level from repeatable read to serializable. Also add create unique index ddl to tinkerbell-init.sql. ## How Has This Been Tested? - Manually ## How are existing users impacted? What migration steps/scripts do we need? - No ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When multiple process concurrently create workflow, the code to access workflow_worker_map is not concurrent safe. This PR fix this issue.
Why is this needed
During workflow creation, new rows may be add to table
workflow_worker_mapin the same transaction. The original design useINSERT ... SELECT. This doesn't work concurrently with SERRIELIZABLE isolation.Fixes: #
INSERT ... ON CONFLICT DO NOTHING;to avoid table lock.How Has This Been Tested?
Manually as #342.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: