Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise create work flow isolation back to Serializable #348

Merged
merged 1 commit into from
Oct 26, 2020

Conversation

ryli17
Copy link
Contributor

@ryli17 ryli17 commented Oct 23, 2020

Description

After PR #346 merged, raise back isolation level from repeatable read to serializable.
Also add create unique index ddl to tinkerbell-init.sql.

How Has This Been Tested?

  • Manually

How are existing users impacted? What migration steps/scripts do we need?

  • No

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #348 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   23.79%   23.79%           
=======================================
  Files          14       14           
  Lines        1244     1244           
=======================================
  Hits          296      296           
  Misses        928      928           
  Partials       20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b230d5...084b6cc. Read the comment docs.

@kqdeng kqdeng self-requested a review October 24, 2020 13:23
@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Oct 26, 2020
@mergify mergify bot merged commit 2683ed2 into tinkerbell:master Oct 26, 2020
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants