Remove gRPC TLS cert #423
Merged
Remove gRPC TLS cert #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way we to TLS in Tinkerbell is just a complication. It does not increase security because everybody that knows how to download the certificate from the tink-server can connect. It can't be used to identify the requester and it means that is not a carrier that we can use for authorisation moving forward. With a couple of other maintainers we would like to remove TLS completely for now until we can figure out a better design for it. Signed-off-by: Gianluca Arbezzano <[email protected]>
gianarb
added
the
breaking-change
mmlb
approved these changes
Jan 26, 2021
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
=======================================
Coverage 34.34% 34.34%
=======================================
Files 46 46
Lines 2865 2865
=======================================
Hits 984 984
Misses 1794 1794
Partials 87 87 Continue to review full report at Codecov.
|
|
What about removing the generate_certificates function in setup.sh from the sandbox repo? |
|
Hey @fransvanberckel will do as a follow-up. I want to get the vibe of this #422 first :) |
This was referenced Jan 26, 2021
jacobweinstock
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way we do TLS in Tinkerbell is just a complication.
It does not increase security because everybody that knows how to
download the certificate from the tink-server can connect.
It can't be used to identify the requester and it means that
is not a carrier that we can use for authorization moving forward.
With a couple of other maintainers, we would like to remove TLS
completely for now until we can figure out a better design for it.
how to migrate
You can update Hegel and boots as well to a versioning that has this patch:
Signed-off-by: Gianluca Arbezzano [email protected]