Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove gRPC TLS cert" #424

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Jan 26, 2021

Reverts #423

The ready-to-merge label got assigned to early! Sorry @mmlb

@gianarb gianarb requested a review from mmlb January 26, 2021 14:08
@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Jan 26, 2021
@gianarb gianarb requested a review from thebsdbox January 26, 2021 14:11
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #424 (147da2f) into master (c3aca06) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #424   +/-   ##
=======================================
  Coverage   34.34%   34.34%           
=======================================
  Files          46       46           
  Lines        2865     2865           
=======================================
  Hits          984      984           
  Misses       1794     1794           
  Partials       87       87           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3aca06...147da2f. Read the comment docs.

Copy link
Contributor

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@gianarb gianarb removed the request for review from mmlb January 26, 2021 14:16
@mergify mergify bot merged commit 55ef43e into master Jan 26, 2021
@mergify mergify bot deleted the revert-423-feat/remove-grpc-cert branch January 26, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants