fix ReportActionStatus panic #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
displague
force-pushed
the
report-action-status-panic
branch
from
6d06134 to
6c0f5f6
Compare
|
@displague Can you take a look at the error and rebase? |
Signed-off-by: Marques Johansson <[email protected]>
gauravgahlot
force-pushed
the
report-action-status-panic
branch
from
d5b53d2 to
b6b68f4
Compare
Signed-off-by: Gaurav Gahlot <[email protected]>
gauravgahlot
force-pushed
the
report-action-status-panic
branch
from
b6b68f4 to
1e94ce1
Compare
gauravgahlot
previously approved these changes
Apr 29, 2022
Signed-off-by: Gaurav Gahlot <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #576 +/- ##
==========================================
- Coverage 44.39% 44.37% -0.03%
==========================================
Files 61 61
Lines 3489 3491 +2
==========================================
Hits 1549 1549
- Misses 1857 1858 +1
- Partials 83 84 +1
Continue to review full report at Codecov.
|
gauravgahlot
approved these changes
Apr 29, 2022
3 tasks
mergify bot
added a commit
that referenced
this pull request
Jul 6, 2022
## Description This allows the final action in a workflow to successfully report its status and consequently allow a workflow to complete. This issue: #559 incorrectly describes a fix that was applied in this PR: #576 ## Why is this needed Fixes: tinkerbell/playground#143 ## How Has This Been Tested? Unit tests were added and the sandbox (vagrant virtualbox quickstart) was used to manually test. ## How are existing users impacted? What migration steps/scripts do we need? ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [x] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applies the suggested fix from #559 (with a different error message).
I'm not familiar with this code but wanted to get a PR started.
Why is this needed
GRPC server panics when the index is over limit.
Fixes: #559
How Has This Been Tested?
Not tested.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: