Fix failure when reporting final action: #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
added
priority/critical-urgent
Codecov Report
@@ Coverage Diff @@
## main #632 +/- ##
==========================================
- Coverage 44.63% 44.43% -0.20%
==========================================
Files 61 61
Lines 3524 3497 -27
==========================================
- Hits 1573 1554 -19
+ Misses 1869 1862 -7
+ Partials 82 81 -1
Continue to review full report at Codecov.
|
This allows the final action in a workflow to successfully report its status and consequently allow a workflow to complete. Signed-off-by: Jacob Weinstock <[email protected]> Signed-off-by: Manuel Mendez <[email protected]>
mmlb
force-pushed
the
final-action-report-error
branch
from
f76203d to
8c5a987
Compare
|
Thanks, I changed the |
mmlb
approved these changes
Jul 6, 2022
3 tasks
mergify bot
added a commit
to tinkerbell/playground
that referenced
this pull request
Aug 2, 2022
## Description The current image that is used in the main branch doesn't work due to the issue which is reported here: #143. There was a PR which addressed this issue already which can be found here tinkerbell/tink#632. This PR uses the latest `tink-server`, `tink-worker` and `tink-cli` which has the fix already in place. ## Why is this needed Fixes: # ## How Has This Been Tested? - Checked out the main branch - Update the env var `vTINK` to `sha-16186501` - Run docker compose - Provision all the needed manifests(HW, WFL, TPL) - Reboot the machine ## How are existing users impacted? What migration steps/scripts do we need? I haven't updated any other components or image except the tink image. ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
ttwd80
pushed a commit
to ttwd80/tinkerbell-playground
that referenced
this pull request
Sep 7, 2024
…ell#146) ## Description The current image that is used in the main branch doesn't work due to the issue which is reported here: tinkerbell#143. There was a PR which addressed this issue already which can be found here tinkerbell/tink#632. This PR uses the latest `tink-server`, `tink-worker` and `tink-cli` which has the fix already in place. ## Why is this needed Fixes: # ## How Has This Been Tested? - Checked out the main branch - Update the env var `vTINK` to `sha-16186501` - Run docker compose - Provision all the needed manifests(HW, WFL, TPL) - Reboot the machine ## How are existing users impacted? What migration steps/scripts do we need? I haven't updated any other components or image except the tink image. ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows the final action in a workflow to successfully report its status and consequently allow a workflow to complete.
This issue: #559 incorrectly describes a fix that was applied in this PR: #576
Why is this needed
Fixes: tinkerbell/playground#143
How Has This Been Tested?
Unit tests were added and the sandbox (vagrant virtualbox quickstart) was used to manually test.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: