Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "prev" command in 1.3 #184

Closed
tjwebb opened this issue Jun 29, 2014 · 13 comments
Closed

remove "prev" command in 1.3 #184

tjwebb opened this issue Jun 29, 2014 · 13 comments

Comments

@tjwebb
Copy link
Collaborator

tjwebb commented Jun 29, 2014

what are everyone's thoughts on this? I personally find it more confusing than helpful, and prone to off-by-one situations

@jbnicolai
Copy link
Contributor

I personally like it to be quite honest 😄

I would like to further suggest implementing n - as an alias for n prev, in a similair version cd - wil change to the previous directory and git checkout - will checkout the previous branch, tag or commit.

Would a PR for this be welcome?

@tjwebb
Copy link
Collaborator Author

tjwebb commented Jul 6, 2014

n - already is an alias for n rm. I'm more inclined to consider API addition/removal than a re-defining an existing command to mean something else.

@jbnicolai
Copy link
Contributor

Wasn't aware of that, you're completely right that we shouldn't use - then. I would suggest even removing that command, as it's very unintuitive.

I'd leave prev though :)

@tjwebb
Copy link
Collaborator Author

tjwebb commented Jul 6, 2014

I'd consider that as well. I don't have much use for aliases anyway. There shouldn't be lots of ways to do one thing, especially in such a simple tool.

@jbnicolai
Copy link
Contributor

👍

@tjwebb tjwebb added the 1.3.x label Jul 6, 2014
@ghost
Copy link

ghost commented Mar 26, 2015

👍

I never use prev. I would just switch to the version number. It's not like we are typing that much more to achieve the same outcome.

@maxrimue
Copy link
Contributor

👍 Same over here

@ghost
Copy link

ghost commented Mar 30, 2015

I am going to submit a PR to remove this.

I ran into an interesting case that breaks the state of n when using prev.

n 0.12.0
n 0.12.1 - prev store 0.12.0
n rm 0.12.0
n prev - script runs and nothing is copied. Active is not set to a value.
n - select comes up and nothing works. Only another call to n prev will fix it.

@tjwebb
Copy link
Collaborator Author

tjwebb commented Mar 30, 2015

I think prev is weird also
On Mar 30, 2015 2:00 PM, "tedgaydos" [email protected] wrote:

I am going to submit a PR to remove this.

I ran into an interesting case that breaks the state of n when using prev.

n 0.12.0

installs 0.12.0
n 0.12.1
installs 0.12.1 and prev store 0.12.0
n rm 0.12.0
removes 0.12.0
n prev
script runs and nothing is copied. Active is not set to a value.
n
select comes up and nothing works. Only another call to n prev will fix it.


Reply to this email directly or view it on GitHub
#184 (comment).

@tjwebb
Copy link
Collaborator Author

tjwebb commented Mar 30, 2015

This would have to constitute a new major version, though. Because semver

@knownasilya
Copy link
Contributor

I use n prev, mainly for cleanup in https://github.com/Strider-CD/strider-node. Also when switching, and forgetting to check what it was before.

@ghost
Copy link

ghost commented Apr 9, 2015

I just took a look at your project. I have to say it is very impressive. Good work.

As for the way you are using n prev, if you want leave the original environment intact, you can use n (io) use to execute under a specific node/io.js version. That way you do not have to worry about cleanup at all.

@ghost ghost added 2.0.0 and removed 1.3.x labels Jul 22, 2015
@ghost
Copy link

ghost commented Jul 22, 2015

prev was pulled in 2.0.0.

@ghost ghost closed this as completed Jul 22, 2015
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants