-
-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove prev, iojs alias, add quiet mode and more. #256
Conversation
👍 Looks good! |
Just updated the PR. Put version to 2.0.0 and using |
Can we pull out |
@tjwebb I merged upstream to clear any conflicts. What is your take on this PR? |
…call to curl. Allow wget fallback.
I wish it were only one feature. It'll take a little awhile to review |
Are we jumping from 1.3.0 to 2.0.0? |
I say split it out into several PRs, ones that require a major bump and ones that don't. |
@tedgaydos yea as I mentioned, a PR should contain one thing. No progress on the review, haven't had time. It'll be easier to review if it were multiple PRs, and I agree with @knownasilya |
This is a major API change. If we merge these changes, we should update to 2.0.0. 👍 |
I agree with @knownasilya and @tjwebb. Multiple pull requests that can eventually push this to 2.0.0. |
I will break it up tonight. |
@tedgaydos very nice! |
@tjwebb It is separated into new PRs. I am closing this one. |
Some changes to the script, readme file and package.json file.
prev
from the script and documentation as discussed in issue remove "prev" command in 1.3 #184.iojs
alias from the script and documentation because it never worked as described in issue iojs alias does nothing #255.-q
or--quiet
) for curl to not display the progress bar as requested in issue Optional Progress Bar #205.install
function where curl was hard coded to get the tarball instead of what is set in the GET variable.tarball_url
in theinstall
function below the test for an already installed version. It is a waste to build the url every time and not use it.n io stable
andn io --stable
but they still work. They actually work correctly now forio
by always calling latest. This was brought up in issuen io stable
will installio-v1.2.0
instead of v1.3.0 #230 and I sat on it for a bit. I decided that this would be best for now because it provides backward compatibility.I also added some minor items from other PRs:
#241 - Added Gitter badge
#239 - Calling
n bin
would not advance the shell prompt to a new line. I just switchedprintf
toecho
.One final item I pulled is the
node
keyword which calledset_default
. It looks like noise because the default state forn
would be to install node. I also need the keyword for a feature request in issue #185. To preserve script state I had to add separate functions to install latest and stable so it remembers which mirror to use.And as @tjwebb said in issue #184 the version was changed to 1.4.0 in the script and package.json files. Or should it be 2.0.0? And if we go to version 2.0.0, maybe I should just make calls to
n io (--)stable
abort?