Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ab: add Brazilian Portuguese translation #2941

Merged
merged 8 commits into from
May 7, 2019

Conversation

andrik
Copy link
Collaborator

@andrik andrik commented Apr 22, 2019

  • The page (if new), does not already exist in the repo.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.

@sbrl sbrl added the translation Issues requesting translating pages from English to other languages. label Apr 22, 2019
pages.pt-BR/common/ab.md Outdated Show resolved Hide resolved
Remove unnecessary emphasis on words that will not be translated

Co-Authored-By: andrik <[email protected]>
Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if that wasn't obvious, I meant all italics words, not only the one in the description.

pages.pt-BR/common/ab.md Outdated Show resolved Hide resolved
pages.pt-BR/common/ab.md Outdated Show resolved Hide resolved
Copy link
Member

@mebeim mebeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looks ok as far as I can tell. I'll leave one of you guys to check and merge @schneiderl @waldyrious. Thank you for the translation @andrik 🙂

> Ferramenta de benchmarking do servidor Apache. A ferramenta mais simples para realizar testes de carga.
> Página oficial: <https://httpd.apache.org/docs/2.4/programs/ab.html>.

- Executar 100 requisições HTTP do tipo GET para uma determinada URL:
Copy link
Member

@waldyrious waldyrious Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest wrapping HTTP and GET in backticks (same for similar code words in this page).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would that be necessary? Those are not other command names or special tokens. I've never seen backticks used in such cases in other pages.

See the following pages for example:

- Create an ext2 filesystem in partition 1 of device b (`sdb1`):

- Assemble `source.asm` into a binary file `source`, in the (default) raw binary format:

- Forward search for a string (press `n`/`N` to go to next/previous match):

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mebeim in my understanding, backticks serve to identify specific technical terms amidst regular English prose, such as commands, filenames, keyboard shortcuts, etc.

Granted, in this sentence HTTP could perhaps be considered a regular acronym, like URL, and be left unmarked; but GET is a specific HTTP verb that carries technical meaning in this context, so I still think it should be marked as code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I would personally only use backticks for tokens and command names, but I get your point.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion above, was:

HTTP could perhaps be considered a regular acronym, like URL, and be left unmarked

so I'd only insist in "backticking" GET and POST (which are not acronyms, btw), again for the reason I suggested above:

GET is a specific HTTP verb that carries technical meaning in this context, so I still think it should be marked as code.

Is that still a deal-breaker to you, @mebeim? From my reading of the discussion above it looks like this would be fine with @sbrl (but please confirm as well).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waldyrious I mean, for what I see that's not coherent with the rest of the pages. If we want to change GET into GET and POST into POST then we'd also have to change it elsewhere, not only in this page. Few examples:

- Send form-encoded data (POST request of type `application/x-www-form-urlencoded`):

- Filter a saved traffic file to just POST requests:

- Send a GET request (default method with no request data):

- Send a POST request (default method with request data):

I also never saw GET or POST be treated specially inside code blocks in any README.md, Markdown documentation, blog posts, et cetera, so I don't really think that's necessary.

However, with the above being said, I would not argue if the majority of us thinks it's better to have those wrapped in backticks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the change would need to happen in other pages as well to be consistent, but I don't think it's problematic to have this page kick-off that change and a later PR making the equivalent change to all other pages.

But if you guys either disagree with adding backticks to GET/POST etc. (I think both @andrik and @sbrl were OK with that, but please confirm), or think it's better for that change to happen entirely in a separate PR, that'd be fine by me.

Copy link
Collaborator Author

@andrik andrik May 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waldyrious I can make this change to all pages, but I think it would be better in a separate PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unresolving this conversation to make it more discoverable. We had some trouble re-locating it in #3114 😅

pages.pt-BR/common/ab.md Outdated Show resolved Hide resolved
@waldyrious waldyrious self-requested a review May 7, 2019 13:19
Copy link
Member

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrik for the contribution and your patience :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation Issues requesting translating pages from English to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants