Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ab: add Brazilian Portuguese translation #2941

Merged
merged 8 commits into from
May 7, 2019
Merged

ab: add Brazilian Portuguese translation #2941

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f23d4fd
ab: add Brazilian Portuguese translation
andrik Apr 22, 2019
276dbe4
ab: remove unnecessary emphasis
mebeim Apr 23, 2019
40fae23
ab: remove all emphasis from english words that will not be translated
andrik Apr 23, 2019
19ef46f
Update pages.pt-BR/common/ab.md
mebeim Apr 23, 2019
34c0c5b
Update pages.pt-BR/common/ab.md
mebeim Apr 23, 2019
4659635
Merge branch 'common_ab_pt_br' of github.com:andrik/tldr into common_…
andrik May 4, 2019
44d008b
Modified some items discussed on PR
andrik May 4, 2019
b3ae539
Fix missing new line after command name and description
andrik May 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions pages.pt-BR/common/ab.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# ab

> Ferramenta da Apache para realizar benchmarking e testes de carga em servidores web.
> Página oficial: <https://httpd.apache.org/docs/2.4/programs/ab.html>.

- Executar 100 requisições HTTP do tipo GET para uma determinada URL:
Copy link
Member

@waldyrious waldyrious Apr 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest wrapping HTTP and GET in backticks (same for similar code words in this page).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would that be necessary? Those are not other command names or special tokens. I've never seen backticks used in such cases in other pages.

See the following pages for example:

tldr/pages/linux/mke2fs.md

Line 5 in 9c59940

- Create an ext2 filesystem in partition 1 of device b (`sdb1`):

tldr/pages/common/nasm.md

Line 5 in 9c59940

- Assemble `source.asm` into a binary file `source`, in the (default) raw binary format:

tldr/pages/common/less.md

Line 17 in 9c59940

- Forward search for a string (press `n`/`N` to go to next/previous match):

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mebeim in my understanding, backticks serve to identify specific technical terms amidst regular English prose, such as commands, filenames, keyboard shortcuts, etc.

Granted, in this sentence HTTP could perhaps be considered a regular acronym, like URL, and be left unmarked; but GET is a specific HTTP verb that carries technical meaning in this context, so I still think it should be marked as code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I would personally only use backticks for tokens and command names, but I get your point.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion above, was:

HTTP could perhaps be considered a regular acronym, like URL, and be left unmarked

so I'd only insist in "backticking" GET and POST (which are not acronyms, btw), again for the reason I suggested above:

GET is a specific HTTP verb that carries technical meaning in this context, so I still think it should be marked as code.

Is that still a deal-breaker to you, @mebeim? From my reading of the discussion above it looks like this would be fine with @sbrl (but please confirm as well).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waldyrious I mean, for what I see that's not coherent with the rest of the pages. If we want to change GET into GET and POST into POST then we'd also have to change it elsewhere, not only in this page. Few examples:

tldr/pages/common/curl.md

Line 18 in dbf4e99

- Send form-encoded data (POST request of type `application/x-www-form-urlencoded`):

tldr/pages/common/mitmdump.md

Line 10 in dbf4e99

- Filter a saved traffic file to just POST requests:

tldr/pages/linux/httpie.md

Line 5 in dbf4e99

- Send a GET request (default method with no request data):

tldr/pages/linux/httpie.md

Line 9 in dbf4e99

- Send a POST request (default method with request data):

I also never saw GET or POST be treated specially inside code blocks in any README.md, Markdown documentation, blog posts, et cetera, so I don't really think that's necessary.

However, with the above being said, I would not argue if the majority of us thinks it's better to have those wrapped in backticks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the change would need to happen in other pages as well to be consistent, but I don't think it's problematic to have this page kick-off that change and a later PR making the equivalent change to all other pages.

But if you guys either disagree with adding backticks to GET/POST etc. (I think both @andrik and @sbrl were OK with that, but please confirm), or think it's better for that change to happen entirely in a separate PR, that'd be fine by me.

Copy link
Collaborator Author

@andrik andrik May 4, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@waldyrious I can make this change to all pages, but I think it would be better in a separate PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unresolving this conversation to make it more discoverable. We had some trouble re-locating it in #3114 😅


`ab -n {{100}} {{url}}`

- Executar 100 requisições HTTP do tipo GET para uma determinada URL, executando 10 requisições simultâneas de cada vez:

`ab -n {{100}} -c {{10}} {{url}}`

- Utilizar a funcionalidade HTTP Keep Alive, permitindo que várias requisições sejam feitas em uma sessão HTTP:

`ab -k {{url}}`

- Definir o tempo total do benchmarking, em segundos:

`ab -t {{60}} {{url}}`