fix: clippy gh action and linting #531
Conversation
| @@ -60,6 +60,7 @@ impl<Ctx: Context> MpcAesGcm<Ctx> { | |||
| } | |||
|
|
|||
| #[async_trait] | |||
| #[allow(clippy::blocks_in_conditions)] | |||
There was a problem hiding this comment.
this needs to be declared due to this upstream issue rust-lang/rust-clippy#12281 — we shall file a ticket to remove this declaration once the upstream fix is released
| if server_closed && client.plaintext_is_empty() && client.buffer_len().await? == 0 { | ||
| break 'conn; |
There was a problem hiding this comment.
we don't want to create the client.buffer_len() future unless the first two conditions are met.
There was a problem hiding this comment.
I think Rust short-circuits https://stackoverflow.com/questions/53644809/do-logical-operators-short-circuit-in-rust
.github/workflows/ci.yml
Outdated
There was a problem hiding this comment.
The simpler solution to this is to just add #[allow(clippy::all)] at in the lib.rs of the tls client crate
| @@ -89,6 +89,7 @@ impl<C, Ctx> Debug for Ghash<C, Ctx> { | |||
| } | |||
|
|
|||
| #[async_trait] | |||
| #[allow(clippy::blocks_in_conditions)] | |||
There was a problem hiding this comment.
Is this lint here needed? I remember that this was/is some sort of clippy bug.
#373 introduced a change that caused GH
clippyaction to only run on examples folder but not anything else (can check the past CI logs, e.g. https://github.com/tlsnotary/tlsn/actions/runs/9755990843/job/26925478536)).This PR fixes that by running
clippyon all targets (binary, library, example, test, bench). Though since thecomponents/tls/tls-clientcrate contains broken tests that don't compile, cargo hack is used temporarily to exclude the crate when runningclippyin thecomponents/tlsworkspace until the test is fixed.Linting changes from applying
clippyon the entire codebase are included too.