-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clippy gh action and linting #531
Changes from all commits
3818c35
aafb5b7
0aae4cd
54a4eb9
e302537
5439517
885dd7c
9eef733
4d78e00
e361a86
74bdb4a
fb46708
0ae5ba2
13f7722
33234df
df60fec
b873088
bc24a98
7370848
65cb093
0ec4967
12e30ec
146c48d
999703a
ec7222b
0f269b0
6bca631
dc170b5
53b70f1
00bf845
dd253c4
820a13c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,8 +29,8 @@ jobs: | |
- components/prf | ||
- components/tls | ||
- components/tls/tls-mpc | ||
- tlsn | ||
- notary | ||
- tlsn | ||
- tlsn/tests-integration | ||
include: | ||
- package: components/tls/tls-mpc | ||
|
@@ -66,7 +66,7 @@ jobs: | |
components: clippy | ||
|
||
- name: "Clippy" | ||
run: cargo clippy --all-features --examples -- -D warnings | ||
run: cargo clippy --all-features --all-targets -- -D warnings | ||
|
||
- name: Use caching | ||
uses: Swatinem/[email protected] | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
#!/bin/bash | ||
|
||
for package in components/uid-mux components/actors/actor-ot components/cipher components/universal-hash components/aead components/key-exchange components/point-addition components/prf components/tls tlsn; do | ||
for package in components/tls components/cipher components/universal-hash components/aead components/key-exchange components/prf tlsn notary; do | ||
pushd $package | ||
# cargo update | ||
cargo clean | ||
cargo build | ||
cargo test | ||
cargo clippy --all-features -- -D warnings || exit | ||
cargo build || exit | ||
cargo test || exit | ||
popd | ||
done |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -142,10 +142,8 @@ pub fn bind_client<T: AsyncRead + AsyncWrite + Send + Unpin + 'static>( | |
tx_recv_fut = tx_receiver.next().fuse(); | ||
} | ||
|
||
if server_closed && client.plaintext_is_empty() { | ||
if client.buffer_len().await? == 0 { | ||
break 'conn; | ||
} | ||
if server_closed && client.plaintext_is_empty() && client.buffer_len().await? == 0 { | ||
break 'conn; | ||
Comment on lines
+145
to
+146
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we don't want to create the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think Rust short-circuits https://stackoverflow.com/questions/53644809/do-logical-operators-short-circuit-in-rust There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} | ||
|
||
select_biased! { | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this needs to be declared due to this upstream issue rust-lang/rust-clippy#12281 — we shall file a ticket to remove this declaration once the upstream fix is released