chore: change default lint level to warning and deny warnings in CI #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
changed the title
|
This PR seems to have caught some warnings that we missed: https://dev.azure.com/tokio-rs/Tokio/_build/results?buildId=1874&view=logs |
LucioFranco
approved these changes
Aug 9, 2019
| use std::ops; | ||
| use std::sync::atomic::AtomicUsize; | ||
| use std::sync::atomic::Ordering::SeqCst; | ||
| use std::sync::{Arc, Mutex, RwLock, RwLockReadGuard, Weak}; | ||
|
|
||
| #[cfg(feature = "async-traits")] | ||
| use futures_core::ready; |
There was a problem hiding this comment.
It is a change to fix the warnings mentioned in #1416 (comment).
https://dev.azure.com/tokio-rs/Tokio/_build/results?buildId=1874
error: unused import: `futures_core::ready`
--> tokio-sync/src/watch.rs:63:5
|
63 | use futures_core::ready;
| ^^^^^^^^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
error: unused import: `futures_util::pin_mut`
--> tokio-sync/src/watch.rs:65:5
|
65 | use futures_util::pin_mut;
| ^^^^^^^^^^^^^^^^^^^^^
taiki-e
commented
Aug 10, 2019
| @@ -3,6 +3,7 @@ pr: ["master", "std-future"] | |||
|
|
|||
| variables: | |||
| nightly: nightly-2019-07-17 | |||
| RUSTFLAGS: -Dwarnings | |||
There was a problem hiding this comment.
Oh, I forgot to add this to .cirrus.yml.
Update: Filed #1425
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1083 (comment) and rust-lang/futures-rs#1448 (comment).
Solution