chore: change default lint level to warning and deny warnings in CI

azure-pipelines.yml

@@ -3,6 +3,7 @@ pr: ["master", "std-future"]
 
 variables:
   nightly: nightly-2019-07-17
+  RUSTFLAGS: -Dwarnings
 
 jobs:
 # Check formatting

ci/azure-clippy.yml

@@ -12,5 +12,5 @@ jobs:
         cargo clippy --version
       displayName: Install clippy
     - script: |
-        cargo clippy --all --all-features -- -D warnings -A clippy::mutex-atomic
+        cargo clippy --all --all-features -- -A clippy::mutex-atomic
       displayName: cargo clippy --all

tokio-buf/src/lib.rs

@@ -1,11 +1,10 @@
 #![doc(html_root_url = "https://docs.rs/tokio-buf/0.2.0-alpha.1")]
-#![deny(
+#![warn(
     missing_docs,
     missing_debug_implementations,
     unreachable_pub,
     rust_2018_idioms
 )]
-#![cfg_attr(test, deny(warnings))]
 #![doc(test(no_crate_inject, attr(deny(rust_2018_idioms))))]
 
 //! Asynchronous stream of bytes.

tokio-codec/src/lib.rs

@@ -1,6 +1,5 @@
 #![doc(html_root_url = "https://docs.rs/tokio-codec/0.2.0-alpha.1")]
-#![deny(missing_docs, missing_debug_implementations, rust_2018_idioms)]
-#![cfg_attr(test, deny(warnings))]
+#![warn(missing_docs, missing_debug_implementations, rust_2018_idioms)]
 #![doc(test(no_crate_inject, attr(deny(rust_2018_idioms))))]
 
 //! Utilities for encoding and decoding frames.

tokio-codec/tests/codecs.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 use bytes::{BufMut, Bytes, BytesMut};
 use tokio_codec::{BytesCodec, Decoder, Encoder, LinesCodec};

tokio-codec/tests/framed.rs

@@ -1,5 +1,5 @@
 #![feature(async_await)]
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 use tokio::prelude::*;
 use tokio_codec::{Decoder, Encoder, Framed, FramedParts};

tokio-codec/tests/framed_read.rs

@@ -1,5 +1,5 @@
 #![feature(async_await)]
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 use tokio::prelude::*;
 use tokio_codec::{Decoder, FramedRead};

tokio-codec/tests/framed_write.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 use tokio_codec::{Encoder, FramedWrite};
 use tokio_io::AsyncWrite;

tokio-codec/tests/length_delimited.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 use tokio::codec::*;
 use tokio::io::{AsyncRead, AsyncWrite};

tokio-current-thread/src/lib.rs

@@ -1,6 +1,5 @@
 #![doc(html_root_url = "https://docs.rs/tokio-current-thread/0.2.0-alpha.1")]
-#![deny(missing_docs, missing_debug_implementations, rust_2018_idioms)]
-#![cfg_attr(test, deny(warnings))]
+#![warn(missing_docs, missing_debug_implementations, rust_2018_idioms)]
 #![doc(test(no_crate_inject, attr(deny(rust_2018_idioms))))]
 
 //! A single-threaded executor which executes tasks on the same thread from which

tokio-current-thread/tests/current_thread.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use std::any::Any;

tokio-executor/src/lib.rs

@@ -1,6 +1,5 @@
 #![doc(html_root_url = "https://docs.rs/tokio-executor/0.2.0-alpha.1")]
-#![deny(missing_docs, missing_debug_implementations, rust_2018_idioms)]
-#![cfg_attr(test, deny(warnings))]
+#![warn(missing_docs, missing_debug_implementations, rust_2018_idioms)]
 #![doc(test(no_crate_inject, attr(deny(rust_2018_idioms))))]
 
 //! Task execution related traits and utilities.

tokio-executor/tests/enter.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(await_macro, async_await)]
 
 #[test]

tokio-executor/tests/executor.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(await_macro, async_await)]
 
 use tokio_executor::{self, DefaultExecutor};

tokio-fs/examples_old/std-echo.rs

@@ -1,5 +1,4 @@
 //! Echo everything received on STDIN to STDOUT.
-#![deny(deprecated, warnings)]
 #![feature(async_await)]
 
 use tokio_codec::{FramedRead, FramedWrite, LinesCodec};

tokio-fs/src/lib.rs

@@ -1,6 +1,5 @@
 #![doc(html_root_url = "https://docs.rs/tokio-fs/0.2.0-alpha.1")]
-#![deny(missing_docs, missing_debug_implementations, rust_2018_idioms)]
-#![cfg_attr(test, deny(warnings))]
+#![warn(missing_docs, missing_debug_implementations, rust_2018_idioms)]
 #![doc(test(no_crate_inject, attr(deny(rust_2018_idioms))))]
 #![feature(async_await)]
 

tokio-fs/tests/dir.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use futures_util::future;

tokio-fs/tests/file.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use rand::{distributions, thread_rng, Rng};

tokio-fs/tests/link.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use std::fs;

tokio-io/src/lib.rs

@@ -1,6 +1,5 @@
 #![doc(html_root_url = "https://docs.rs/tokio-io/0.2.0-alpha.1")]
-#![deny(missing_debug_implementations, missing_docs, rust_2018_idioms)]
-#![cfg_attr(test, deny(warnings))]
+#![warn(missing_debug_implementations, missing_docs, rust_2018_idioms)]
 #![doc(test(no_crate_inject, attr(deny(rust_2018_idioms))))]
 
 //! Core I/O traits and combinators when working with Tokio.

tokio-io/tests/copy.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use tokio_io::{AsyncRead, AsyncReadExt};

tokio-io/tests/lines.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use futures_util::StreamExt;

tokio-io/tests/read.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use tokio_io::{AsyncRead, AsyncReadExt};

tokio-io/tests/read_exact.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use tokio_io::AsyncReadExt;

tokio-io/tests/read_line.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use std::io::Cursor;

tokio-io/tests/read_to_end.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use tokio_io::AsyncReadExt;

tokio-io/tests/read_to_string.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use tokio_io::AsyncReadExt;

tokio-io/tests/read_until.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use tokio_io::AsyncBufReadExt;

tokio-io/tests/write.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use tokio_io::{AsyncWrite, AsyncWriteExt};

tokio-io/tests/write_all.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use tokio_io::{AsyncWrite, AsyncWriteExt};

tokio-macros/src/lib.rs

@@ -1,6 +1,5 @@
 #![doc(html_root_url = "https://docs.rs/tokio-macros/0.2.0-alpha.1")]
-#![deny(missing_debug_implementations, unreachable_pub, rust_2018_idioms)]
-#![cfg_attr(test, deny(warnings))]
+#![warn(missing_debug_implementations, unreachable_pub, rust_2018_idioms)]
 #![doc(test(no_crate_inject, attr(deny(rust_2018_idioms))))]
 
 //! Macros for use with Tokio

tokio-process/src/lib.rs

@@ -118,8 +118,7 @@
 //! be regained with the `Child::forget` method.
 
 #![doc(html_root_url = "https://docs.rs/tokio-process/0.3.0")]
-#![deny(missing_debug_implementations, missing_docs, rust_2018_idioms)]
-#![cfg_attr(test, deny(warnings))]
+#![warn(missing_debug_implementations, missing_docs, rust_2018_idioms)]
 #![doc(test(no_crate_inject, attr(deny(rust_2018_idioms))))]
 #![feature(async_await)]
 

tokio-process/tests/issue_42.rs

@@ -1,5 +1,5 @@
 #![cfg(unix)]
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 use futures_util::future::FutureExt;
 use futures_util::stream::FuturesOrdered;

tokio-process/tests/smoke.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use tokio_process::CommandExt;

tokio-process/tests/stdio.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 #[macro_use]

tokio-process/tests/support/mod.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 use futures_util::future;
 use futures_util::future::FutureExt;

tokio-reactor/benches/basic.rs

@@ -1,5 +1,5 @@
 #![feature(test)]
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 /*
 extern crate test;

tokio-reactor/src/lib.rs

@@ -1,6 +1,5 @@
 #![doc(html_root_url = "https://docs.rs/tokio-reactor/0.2.0-alpha.1")]
-#![deny(missing_docs, missing_debug_implementations, rust_2018_idioms)]
-#![cfg_attr(test, deny(warnings))]
+#![warn(missing_docs, missing_debug_implementations, rust_2018_idioms)]
 #![doc(test(no_crate_inject, attr(deny(rust_2018_idioms))))]
 
 //! Event loop that drives Tokio I/O resources.

tokio-signal/examples/ctrl-c.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use futures_util::stream::StreamExt;

tokio-signal/examples/multiple.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 //! A small example of how to listen for two signals at the same time

tokio-signal/examples/sighup-example.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 // A trick to not fail build on non-unix platforms when using unix-specific features.

tokio-signal/src/lib.rs

@@ -1,6 +1,5 @@
 #![doc(html_root_url = "https://docs.rs/tokio-signal/0.3.0-alpha.1")]
-#![deny(missing_debug_implementations, missing_docs, rust_2018_idioms)]
-#![cfg_attr(test, deny(warnings))]
+#![warn(missing_debug_implementations, missing_docs, rust_2018_idioms)]
 #![cfg_attr(test, feature(async_await))]
 #![doc(test(no_crate_inject, attr(deny(rust_2018_idioms))))]
 

tokio-signal/tests/drop_multi_loop.rs

@@ -1,5 +1,5 @@
 #![cfg(unix)]
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 use libc;
 

tokio-signal/tests/drop_then_get_a_signal.rs

@@ -1,5 +1,5 @@
 #![cfg(unix)]
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use libc;

tokio-signal/tests/dropping_does_not_deregister_other_instances.rs

@@ -1,5 +1,5 @@
 #![cfg(unix)]
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 use libc;

tokio-signal/tests/multi_loop.rs

@@ -1,5 +1,5 @@
 #![cfg(unix)]
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 pub mod support;
 use crate::support::*;

tokio-signal/tests/notify_both.rs

@@ -1,5 +1,5 @@
 #![cfg(unix)]
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 pub mod support;

tokio-signal/tests/simple.rs

@@ -1,5 +1,5 @@
 #![cfg(unix)]
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 pub mod support;

tokio-signal/tests/support.rs

@@ -1,5 +1,5 @@
 #![cfg(unix)]
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 use futures_util::future::FutureExt;
 use libc::{c_int, getpid, kill};

tokio-signal/tests/twice.rs

@@ -1,5 +1,5 @@
 #![cfg(unix)]
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 #![feature(async_await)]
 
 pub mod support;

tokio-sync/benches/mpsc.rs

@@ -1,5 +1,5 @@
 #![feature(test)]
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 extern crate test;
 

tokio-sync/benches/oneshot.rs

@@ -1,5 +1,5 @@
 #![feature(test)]
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 extern crate test;
 

tokio-sync/src/lib.rs

@@ -1,11 +1,10 @@
 #![doc(html_root_url = "https://docs.rs/tokio-sync/0.2.0-alpha.1")]
-#![deny(
+#![warn(
     missing_debug_implementations,
     missing_docs,
     unreachable_pub,
     rust_2018_idioms
 )]
-#![cfg_attr(test, deny(warnings))]
 #![doc(test(no_crate_inject, attr(deny(rust_2018_idioms))))]
 #![feature(async_await)]
 

tokio-sync/src/watch.rs

@@ -60,14 +60,16 @@ use crate::task::AtomicWaker;
 use core::task::Poll::{Pending, Ready};
 use core::task::{Context, Poll};
 use fnv::FnvHashMap;
-use futures_core::ready;
 use futures_util::future::poll_fn;
-use futures_util::pin_mut;
 use std::ops;
 use std::sync::atomic::AtomicUsize;
 use std::sync::atomic::Ordering::SeqCst;
 use std::sync::{Arc, Mutex, RwLock, RwLockReadGuard, Weak};
 
+#[cfg(feature = "async-traits")]
+use futures_core::ready;
+#[cfg(feature = "async-traits")]
+use futures_util::pin_mut;
 #[cfg(feature = "async-traits")]
 use std::pin::Pin;
 

tokio-sync/tests/atomic_waker.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 use std::task::Waker;
 use tokio_sync::AtomicWaker;

tokio-sync/tests/errors.rs

@@ -1,4 +1,4 @@
-#![deny(warnings, rust_2018_idioms)]
+#![warn(rust_2018_idioms)]
 
 fn is_error<T: ::std::error::Error + Send + Sync>() {}