Skip to content

Commit

Permalink
chore: ignore all target dirs (#150)
Browse files Browse the repository at this point in the history
* chore: ignore all target dirs

The gitignore for this repository currently includes the pattern
`/*/target`, which will ignore all directories named `target` that are
nested up to one directory deep from the root. This ignores the target
dir for the workspace, and any generated by builds on individual
workspace crates. However, the `tracing` crate contains test crates
which cannot be part of the workspace, due to setting feature flags.
These crates are inside the `tracing` crate's subdirectory, so the
`target` dirs generated by running these tests are nested _two_ levels
deep. Git doesn't know to ignore the generated files from the test
dirs, which is kind of annoying.

This branch changes the ignore pattern to `/**/target`, which should
ignore _all_ subdirectories named `target`. This does have the potential
downside that if any crate adds a module called `target`, we'd have to
update the gitignore, but I'm not _too_ concerned currently.

Signed-off-by: Eliza Weisman <[email protected]>
  • Loading branch information
hawkw authored Jul 5, 2019
1 parent 0e02d6d commit f771996
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ Temporary Items
### Rust ###
# Generated by Cargo
# will have compiled files and executables
/target/
/*/target/
target/

# Remove Cargo.lock from gitignore if creating an executable, leave it for libraries
# More information here https://doc.rust-lang.org/cargo/guide/cargo-toml-vs-cargo-lock.html
Expand Down

0 comments on commit f771996

Please sign in to comment.