Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The gitignore for this repository currently includes the pattern
/*/target
, which will ignore all directories namedtarget
that arenested up to one directory deep from the root. This ignores the target
dir for the workspace, and any generated by builds on individual
workspace crates. However, the
tracing
crate contains test crateswhich cannot be part of the workspace, due to setting feature flags.
These crates are inside the
tracing
crate's subdirectory, so thetarget
dirs generated by running these tests are nested two levelsdeep. Git doesn't know to ignore the generated files from the test
dirs, which is kind of annoying.
Solution
This branch changes the ignore pattern to
/**/target
, which shouldignore all subdirectories named
target
. This does have the potentialdownside that if any crate adds a module called
target
, we'd have toupdate the gitignore, but I'm not too concerned currently.
Signed-off-by: Eliza Weisman [email protected]