Merge pull request #136 from topolvm/stop-logging-createOrUpdateJob

stop logging of createOrUpdateJob
topolvm · Oct 9, 2024 · 6100e49 · 6100e49
2 parents 2de6460 + e612334
commit 6100e49
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/internal/controller/pie/pieprobe_controller.go b/internal/controller/pie/pieprobe_controller.go
@@ -353,17 +353,15 @@ func (r *PieProbeReconciler) createOrUpdateJob(
 	pieProbe *piev1alpha1.PieProbe,
 	nodeName *string,
 ) error {
-	logger := log.FromContext(ctx)
-	logger.Info("createOrUpdateJob")
-	defer logger.Info("createOrUpdateJob Finished")
+	_ = log.FromContext(ctx)
 
 	cronjob := &batchv1.CronJob{}
 	cronjob.SetNamespace(pieProbe.GetNamespace())
 	cronjob.SetName(getCronJobName(kind, nodeName, pieProbe))
 
 	storageClass := pieProbe.Spec.MonitoringStorageClass
 
-	op, err := ctrl.CreateOrUpdate(ctx, r.client, cronjob, func() error {
+	_, err := ctrl.CreateOrUpdate(ctx, r.client, cronjob, func() error {
 		label := map[string]string{
 			constants.ProbeStorageClassLabelKey: storageClass,
 			constants.ProbePieProbeLabelKey:     pieProbe.GetName(),
@@ -491,9 +489,7 @@ func (r *PieProbeReconciler) createOrUpdateJob(
 	if err != nil {
 		return fmt.Errorf("failed to create CronJob: %s", getCronJobName(kind, nodeName, pieProbe))
 	}
-	if op != controllerutil.OperationResultNone {
-		logger.Info(fmt.Sprintf("CronJob successfully created: %s", getCronJobName(kind, nodeName, pieProbe)))
-	}
+
 	return nil
 }