stop logging of createOrUpdateJob #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llamerada-jp
reviewed
Oct 7, 2024
ushitora-anqou
force-pushed
the
stop-logging-createOrUpdateJob
branch
from
3126726 to
5af7da9
Compare
Indeed. I removed this logging, too. |
The current implementation of createOrUpdateJob prints a lot of info logs. For example, it prints "createOrUpdate" and "createOrUpdateJob Finished" info logs every time the function runs, both before and after execution. Since this function is called repeatedly from the reconciliation loop, these logs are generated excessively. However, they don't provide any meaningful information and clutter the log readability. This commit removes these logs to make the logs for pie much clearer. Signed-off-by: Ryotaro Banno <[email protected]>
ushitora-anqou
force-pushed
the
stop-logging-createOrUpdateJob
branch
from
5af7da9 to
e612334
Compare
llamerada-jp
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of createOrUpdateJob prints "createOrUpdate" and "createOrUpdateJob Finished" info logs every time the function runs, both before and after execution. Since this function is called repeatedly from the reconciliation loop, these logs are generated excessively. However, they don't provide any meaningful information and clutter the log readability.
This commit removes these logs to make the logs for pie much clearer.