Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Setup Bitrise CI 🤖 #8

Merged
merged 8 commits into from
Feb 28, 2018
Merged

Setup Bitrise CI 🤖 #8

merged 8 commits into from
Feb 28, 2018

Conversation

toshi0383
Copy link
Owner

No description provided.

@codecov-io
Copy link

codecov-io commented Feb 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@f178458). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master      #8   +/-   ##
========================================
  Coverage          ?   0.65%           
========================================
  Files             ?      27           
  Lines             ?     910           
  Branches          ?       0           
========================================
  Hits              ?       6           
  Misses            ?     904           
  Partials          ?       0
Impacted Files Coverage Δ
BitriseClient/Sources/AppDelegate.swift 18.18% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f178458...2f0a36b. Read the comment docs.

@@ -16,6 +16,10 @@ class AppDelegate: UIResponder, UIApplicationDelegate {

func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplicationLaunchOptionsKey: Any]?) -> Bool {

if ProcessInfo.processInfo.environment["TEST"] == "YESS" {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YESS is workaround for XcodeGen's buggish behavior: yonaskolb/XcodeGen#253
For CI we need this too. yonaskolb/XcodeGen#254 => I'm using my fork XcodeGen for CI https://github.com/toshi0383/XcodeGen/releases/tag/1.6.2)

@toshi0383
Copy link
Owner Author

Green green green✅🏎🏁

@toshi0383 toshi0383 merged commit efd9040 into master Feb 28, 2018
@toshi0383 toshi0383 deleted the empty-test-target branch February 28, 2018 09:24
@toshi0383
Copy link
Owner Author

note: This one is required for CI.
yonaskolb/XcodeGen#248

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants