Fix shouldUseLaunchSchemeArgsEnv disabling logic

[toshi0383]

Adding environmentVariables was not disabling the shouldUseLaunchSchemeArgsEnv flag.
Therefore the process could not read the variables.

[yonaskolb]

@turekj any thoughts, since you implemented the envs?

[yonaskolb]

What about when they’re empty?

[turekj]

That's a great catch! 👍

@yonaskolb the environment variables won't ever be empty in that particular context, because they are re-mapped to nil when empty:

let testVariables = scheme.test.flatMap { $0.environmentVariables.isEmpty ? nil : $0.environmentVariables }

The command line arguments behave the other way I believe, it's a dict that is initialized to empty one by default and profileCommandLineArgs can only be nil if there is no profile scheme. Which means that the change will break the correct behavior.

I think the cleanest solution would be to add an extension on a Profile struct and Test struct that computes that:

extension Profile {
    var shouldUseLaunchSchemeArgsEnv: Bool {
        return commandLineArguments.isEmpty && environmentVariables.isEmpty
    }
}

What do you think @toshi0383?

[toshi0383]

@yonaskolb @turekj Good point. Fixed in 0a37fd5 👌