Fix no default features flags + update cubecl #2725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
run-checks all
script has been executed.Related Issues/PRs
#2709
CubeCL #438
HIP sys #13
Changes
When specifying no default features some crates would inevitably enable the downstream default features for cubecl, which causes issues when trying to specify a conflicting feature. Although feature flags should be additive, this is not exactly the case for cubecl-hip (multiple version flags will fail to build), so for now we can make sure that the downstream flags correspond.