Remove the default feature from cubecl-hip-sys Cargo.toml #13
+102
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laggui
approved these changes
Jan 17, 2025
syl20bnr
force-pushed
the
fix/default-feature
branch
from
47155b2 to
e46f544
Compare
syl20bnr
force-pushed
the
fix/default-feature
branch
3 times, most recently
from
2eab28c to
f9062a8
Compare
syl20bnr
force-pushed
the
fix/default-feature
branch
from
f9062a8 to
301b995
Compare
|
Still working on it, the default feature works but the CI is still erroring out because of cargo-audit. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default feature to select a default version of ROCm prevents users from easily choosing a different version in Burn.
Part of the fix for Burn discussion tracel-ai/burn#2709