MB-15974 - upgrades react-router and react-router-dom versions #10805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 1, 2023
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
felipe-lee
force-pushed
the
kh-upgrade-react-router-6.11.2
branch
from
c91655c to
6205619
Compare
JIRA Ticket: MB-15974
We can't update to the latest versions because it breaks our react-admin site. Per their troubleshooting docs, https://marmelab.com/react-admin/Routing.html#troubleshooting, we need to match the versions they're using, so we need to set resolutions. A bit of a pain because now we'll need to keep them in sync. JIRA Ticket: MB-15974
Needed for the react-router update because of [ #9506 - Fix inadvertent support for partial dynamic parameters](remix-run/react-router#9506). JIRA Ticket: MB-15974 Co-authored-by: Kyle Hill <[email protected]>
felipe-lee
force-pushed
the
kh-upgrade-react-router-6.11.2
branch
from
6205619 to
18ef91c
Compare
felipe-lee
requested review from
a team and
bellex3
and removed request for
a team
rileyorr
approved these changes
Jun 6, 2023
bellex3
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket
Summary
Upgrades react-router and react-router-dom versions. Replaces #10777 and #10754.
We can't update to the latest versions because it breaks our
react-adminsite. Perreact-admin's troubleshooting docs, we need to match the versions they're using, so we need to set resolutions. A bit of a pain because now we'll need to keep them in sync.This update also requires an update to some of our FE routes because the maintainers removed support for partial dynamic parameters. Kyle wrote up some info in a post to inform the design and product teams (post was the same and as of now, only the design one has non-emoji comments on it). Here it is for ease:
Release Notes & Changelog
Release notes
Sourced from react-router's releases.
... (truncated)
Changelog
Sourced from react-router's changelog.
... (truncated)
Commits
0815c96chore: Update version for release (#10500)f1e4db4chore: Update version for release (pre) (#10495)e665a46Fix basename duplication in RouterProvider descendant routes (#10492)db696c1chore: Update version for release (#10443)b725c3bchore: Update version for release (pre) (#10436)c4e9607Fix usage of Navigate in strict mode when using a data router (#10435)5e195ecFix useNAvigate when called from <Routes> inside a <RouterProvider> (#10432)666d962Fix usage of Component API within descendant routes (#10434)7ff51c0chore: Update version for release (#10414)5ec9f8echore: Update version for release (pre) (#10410)Verification Steps for Reviewers
These are to be checked by a reviewer.
ephemeral deployment links:
• https://admin-milmove-pr-10805.mymove.sandbox.truss.coffee/
• https://office-milmove-pr-10805.mymove.sandbox.truss.coffee/
Setup to Run the Code Locally
How to test
Route changes
/new-shipment/:shipmentTyperather than the old pattern of/new-:shipmentType. I.e. you should see something like/new-shipment/PPMrather than/new-PPMEnsuring Admin works
react-routerandreact-router-dom.Frontend
officeAppclass or custommin-widthstyling is used to hide any states the would not be visible to the user.Screenshots