Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B 21557 INT Update Estimated prices for NTS-R Service items on "Previously Recorded Weight" Update #14579

Merged
merged 82 commits into from
Jan 24, 2025
Merged

B 21557 INT Update Estimated prices for NTS-R Service items on "Previously Recorded Weight" Update #14579

merged 82 commits into from
Jan 24, 2025

Conversation

joeydoyecaci
Copy link
Contributor

@joeydoyecaci joeydoyecaci commented Jan 14, 2025 •
edited
Loading

B-21557

B-21557 1st INT PR

Linked Issue I-3766

Summary

How to test

  1. Create a move with an NTS-R, or find an existing move that is already approved
  2. As a SC add an NTS-R shipment to the move and submit the move to SC.
  3. As a TOO, go to the move task order tab, and edit the NTS-R to add a previously recorded weight then save
  4. The service items should have prices associated with them.
  5. Edit the NTS-R shipment again to modify the "previously recorded weight", can be any nonzero value, then save
  6. The values should be updated based on the new estimated weight

loganwc and others added 26 commits October 29, 2024 16:07
@loganwc
estimated prices now calculates for NTS-R shipments
a89fca0
@loganwc
updated comment
78efbd4
@loganwc
now using 110% of estimated weight for NTS-R
0c62a14
@loganwc
Merge branch 'main' into B-21551-NTSR-Estimated-Price
fa2cd85
@loganwc
most of the tests but they don't work
f419625
@loganwc
tests now workgit add .
6783ebc
@loganwc
Merge branch 'main' into B-21551-NTSR-Estimated-Price
2811129
@loganwc
someone deleted a thing i wanted
529b140
@loganwc
Update mto_service_item_creator_test.go
ab2950c
@loganwc
Merge branch 'main' into B-21551-NTSR-Estimated-Price
22f8556
@joeydoyecaci
Merge branch 'main' into B-21557-Estimated-Price
d7dae6a
@joeydoyecaci
Merge branch 'main' into B-21557-Estimated-Price
8e9a05d
@loganwc
Merge branch 'main' into B-21551-NTSR-Estimated-Price
56dec62
@danieljordan-caci
Merge branch 'main' into B-21551-NTSR-Estimated-Price
44caebe
@loganwc
update tests so they work with Dan the Mans changes
0cb1e19
@loganwc
Merge branch 'B-21551-NTSR-Estimated-Price' of github.com:transcom/my…
ccacf68 
…move into B-21551-NTSR-Estimated-Price
@loganwc
Merge branch 'main' into B-21551-NTSR-Estimated-Price
46fe8c2
@loganwc
more daniel madness
7608779
@joeydoyecaci
Merge branch 'main' into B-21557-Estimated-Price
ab5a9bd
@joeydoyecaci
Update to allow shipment weight to update when TOO updates an estimat…
0841ec1 
…ed weight when there was already one added
@joeydoyecaci
Merge branch 'main' into B-21557-Estimated-Price
46f3e14
@joeydoyecaci
Broke out update shipment pricing addition into AddPricingEstimatesTo…
28d9700 
…MTOServiceItems.
@paulstonebraker
Merge branch 'main' into B-21557-Estimated-Price
22dc15f
@paulstonebraker
Merge branch 'main' into B-21557-Estimated-Price
8ed2d2e
@joeydoyecaci
Merge branch 'main' into B-21557-Estimated-Price
29099bc
@joeydoyecaci
Merge branch 'B-21557-Estimated-Price' into B-21557-INT-Estimated-Price
c50ba7e
@joeydoyecaci joeydoyecaci added the INTEGRATION Slated for Integration Testing label Jan 14, 2025
@joeydoyecaci joeydoyecaci self-assigned this Jan 14, 2025
@joeydoyecaci joeydoyecaci requested review from a team as code owners January 14, 2025 18:34
joeydoyecaci and others added 18 commits January 23, 2025 18:23
@joeydoyecaci
Added GetAdjustedWeight and moved 110% modifier
5f18271
@traskowskycaci
Merge branch 'main' into B-21947-MAIN
f364cca
@danieljordan-caci
Merge remote-tracking branch 'origin/main' into MAIN-B-22206
278b1fc
@joeydoyecaci
Merged 21551 changes in
be03459
@traskowskycaci
Merge branch 'main' into B-21947-MAIN
bdd3a7b
@joeydoyecaci
Merge branch 'main' into B-21557-Estimated-Price
0b83b75
@joeydoyecaci
Merge B-21577 Main into B-21577 int
f7a7973
@joeydoyecaci
Merge branch 'integrationTesting' into B-21557-INT-Estimated-Price
ba20fed
@brianmanley-caci
Merge branch 'main' into MAIN-B-21984
13a1a9c
@joeydoyecaci
Merge branch 'integrationTesting' into B-21557-INT-Estimated-Price
829b29c
@brianmanley-caci
Merge pull request #14647 from transcom/MAIN-B-21984
cb302f4 
MAIN-B-21984 Add Move Management Fee to Payment Review
@danieljordan-caci
Merge branch 'main' into MAIN-B-22206
1548227
@danieljordan-caci
Merge branch 'main' into B-21947-MAIN
a10c9e5
@cameroncaci
Merge pull request #14574 from transcom/MAIN-B-22206
1df926b 
MAIN B-22206
@danieljordan-caci
Merge branch 'main' into B-21947-MAIN
abb342f
@cameroncaci
Merge pull request #14634 from transcom/B-21947-MAIN
a6db028 
[PAPI] B-21947 MAIN - Return customer backup contact info in getMoveTaskOrder
@joeydoyecaci
Merge branch 'main' into B-21557-Estimated-Price
a1b042c
@joeydoyecaci
Merge branch 'B-21557-Estimated-Price' into B-21557-INT-Estimated-Price
bd4fc51
loganwc
loganwc approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@loganwc loganwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great, also fixes shipments under 500lbs 🙌

@danieljordan-caci
Copy link
Contributor

Can you link the issue ticket in this PR plz?

@joeydoyecaci
Copy link
Contributor Author

Can you link the issue ticket in this PR plz?

Linked!

@joeydoyecaci joeydoyecaci merged commit 36cd071 into integrationTesting Jan 24, 2025
32 of 33 checks passed
@joeydoyecaci joeydoyecaci deleted the B-21557-INT-Estimated-Price branch January 24, 2025 20:10
@danieljordan-caci danieljordan-caci mentioned this pull request Jan 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pambecker pambecker pambecker approved these changes

@loganwc loganwc loganwc approved these changes

@paulstonebraker paulstonebraker Awaiting requested review from paulstonebraker

@danieljordan-caci danieljordan-caci Awaiting requested review from danieljordan-caci

@JonSpight JonSpight Awaiting requested review from JonSpight

Assignees

@joeydoyecaci joeydoyecaci

Labels
G-Unit Scrum Team G INTEGRATION Slated for Integration Testing
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@joeydoyecaci @pambecker @danieljordan-caci @loganwc @JonSpight @paulstonebraker @brianmanley-caci @traskowskycaci @cameroncaci