Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT B-21978 revert the revert #14671

Merged
merged 9 commits into from
Jan 28, 2025
Merged

INT B-21978 revert the revert #14671

merged 9 commits into from
Jan 28, 2025

Conversation

danieljordan-caci
Copy link
Contributor

@danieljordan-caci danieljordan-caci commented Jan 27, 2025 •
edited
Loading

Agility ticket

Summary

See previous PR here for testing

Only changes in this from that PR:

  • in ppm_estimator, removed a param from ZipTransitDistance that was removed with B-21557
  • this happened AFTER final checks were done on this but before merge of the previous INT PR - thus, the revert
  • this PR reverts the revert & removes the previously removed param

@danieljordan-caci danieljordan-caci self-assigned this Jan 27, 2025
@danieljordan-caci danieljordan-caci added INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time labels Jan 27, 2025
@danieljordan-caci danieljordan-caci marked this pull request as ready for review January 27, 2025 21:55
@danieljordan-caci danieljordan-caci requested review from a team as code owners January 27, 2025 21:55
cameroncaci
cameroncaci previously approved these changes Jan 28, 2025
View reviewed changes
@cameroncaci cameroncaci self-requested a review January 28, 2025 12:33
cameroncaci
cameroncaci reviewed Jan 28, 2025
View reviewed changes
Copy link
Contributor

@cameroncaci cameroncaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs those failing tests to have their params updated too

@danieljordan-caci
Copy link
Contributor Author

Just needs those failing tests to have their params updated too

ready for ya

@danieljordan-caci danieljordan-caci merged commit 2ed5a82 into integrationTesting Jan 28, 2025
33 of 34 checks passed
@danieljordan-caci danieljordan-caci deleted the INT-B-21978-revert-the-revert branch January 28, 2025 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameroncaci cameroncaci cameroncaci approved these changes

@deandreJones deandreJones deandreJones approved these changes

@TevinAdams TevinAdams Awaiting requested review from TevinAdams TevinAdams was automatically assigned from transcom/mountain-movers

@traskowskycaci traskowskycaci Awaiting requested review from traskowskycaci traskowskycaci was automatically assigned from transcom/mountain-movers

Assignees

@danieljordan-caci danieljordan-caci

Labels
INTEGRATION Slated for Integration Testing Mountain Movers Movin' Mountains 1 Sprint at a time
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danieljordan-caci @deandreJones @cameroncaci