Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Int b 22166 #14599

Open
wants to merge 130 commits into
base: integrationTesting
Choose a base branch
from
Open

Int b 22166 #14599

wants to merge 130 commits into from

Conversation

begrohmann
Copy link
Contributor

INT-B-22166

Summary

Adding missing duty locations and associating to counseling offices.
Removing invalid duty locations.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

The following duty locations should not be available for selection:
Meridian, MS 39302
Minneapolis, MN 55460

The following duty locations should be available for selection:
NAS N Island, CA 92135
NAS North Island, CA 92135
San Diego, CA 92135
Cannon AFB, NM 88101

When origin duty location is NAS Meridian, MS 39309 then PPPO FLCJ Meridan Det - USN should be in the Counseling Office dropdown list.

When origin duty location is New London, CT 06320 then PPPO Navy Submarine Base New London - USN should be in the Counseling Office dropdown list.

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

loganwc and others added 30 commits December 16, 2024 17:08
…im-Shipment-Create' into B-21460-Fix-Prime-Sim-Shipment-Create
pambecker and others added 24 commits January 13, 2025 16:51
B-21359 - Backend: Assigned User Cleanup
B 22148 main - Assigned User Cleanup [BE] - PPM Closeout
…on-Gitlab-NFP

B 22110 performance optimization gitlab nfp
B-21937: Allow Doc Uploads/Downloads with Commas
MAIN-B-22133 prime simulator update port
…dation

Main b 21507 pod poe too validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.