Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT B-21424 international SIT - address change, TOO Approval #14802

Merged
merged 13 commits into from
Feb 17, 2025

Conversation

MInthavongsay
Copy link
Contributor

@MInthavongsay MInthavongsay commented Feb 12, 2025

B-21424

Summary

This PR configures application to allow international destination SIT to require TOO approval for delivery address change <= 50 miles from SIT original destination on a shipment to/from CONUS/Alaska and automatic approval for delivery address change > 50 miles from SIT original destination on a shipment to/from CONUS/Alaska. The approval process will be identical to domestic destination SIT.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Login as customer and create/submit HHG with Alaska destination to ensure shipment is marked as OCONUS. ex) JUNEAU, AK 99801
  2. Login as service counselor and move shipment to TOO.
  3. Login as TOO and select HHG and approve to move it to Prime
  4. Login as Prime Sim. Add International Destination Service Item.
  5. Login as TOO and APPROVE at least of the 4 international service items generated for international destination SIT from step 4. Note - if step 5 is not done, a runtime error(todo: handle error more elegantly..etc..) will be thrown if shipment delivery address is updated via Prime(step 6).
  6. Login Prime Sim. Goto Update Shipment Delivery Address and update to address that is less than 50 miles apart from the CURRENT shipment delivery address. This will NOT REQUIRE TOO approval. Note the new address will be visible on details view after updating to new address. Login to TOO and verify address change does not require approval.
  7. Login Prime Sim. Goto Update Shipment Delivery Address and update to address that is greater than 50 miles apart from the CURRENT shipment delivery address. This will require TOO approval. Note the new address will only be visible on details view only if TOO approves the new address change.
  8. Login to TOO. Approve address. Confirmation message should display mileage between new vs original destination address.
    Screenshot 2025-02-12 at 3 53 11 PM
    Screenshot 2025-02-12 at 3 53 46 PM
  9. Try to break it. Anything missing?

NOTE: Use domestic destination SIT as reference. The TOO process for international must be identical to domestic.

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

@MInthavongsay MInthavongsay added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Feb 12, 2025
@MInthavongsay MInthavongsay self-assigned this Feb 12, 2025
@MInthavongsay MInthavongsay changed the title INT B-21424 international SIT - address change INT B-21424 international SIT - address change, TOO Approval Feb 12, 2025
@MInthavongsay MInthavongsay marked this pull request as ready for review February 12, 2025 21:16
@MInthavongsay MInthavongsay requested a review from a team as a code owner February 12, 2025 21:16
Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's due to this work, but I'm getting a SIT-adjacent error when creating a fresh database. Going to work around it for now and circle back once test case is complete
image

@brianmanley-caci
Copy link
Contributor

I don't think it's due to this work, but I'm getting a SIT-adjacent error when creating a fresh database. Going to work around it for now and circle back once test case is complete image

I broke that 😄 It's being fixed here: #14808. It should be in integration shortly.

@antgmann
Copy link
Contributor

I broke that 😄 It's being fixed here: #14808. It should be in integration shortly.

Thanks for fixing it and letting me know!

Copy link
Contributor

@antgmann antgmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing steps work nicely. Going to try to break a couple things and if all goes well, I'll approve shortly!
Pasted Graphic 10

image

Copy link
Contributor

@CoryKleinjanCACI CoryKleinjanCACI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation updates were verified as being currently correct, but may need to be revisited later once diversions are implemented for international shipments as the requirements could change.

Test steps work as expected. Approved.

@MInthavongsay MInthavongsay merged commit 13bb32d into integrationTesting Feb 17, 2025
5 checks passed
@MInthavongsay MInthavongsay deleted the INT-B-21424-Address-Change branch February 17, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

5 participants