Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INT - V2 - B - 21423 prime int sit service item #14804

Conversation

MInthavongsay
Copy link
Contributor

@MInthavongsay MInthavongsay commented Feb 12, 2025

B-21423

Summary

This PR is a follow up to INT PR. It fixes a validation bug to prevent international SITs to be created for domestic shipments and vice versa.

This PR adds functionality to create international SIT service items to Prime (v1). In addition, it also contains the ability to update international SITs and the display of detailed information of SITs on the TOO details view. There are no BLs to address updates and display.

this article explains more about the approach used.

Verification Steps for the Author

These are to be checked by the author.

  • Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
  • Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

  • Has the branch been pulled in and checked out?
  • Have the BL acceptance criteria been met for this change?
  • Was the CircleCI build successful?
  • Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

How to test

  1. Login as customer. Create and submit HHG with Alaska origin and/or destination addresses.
  2. Login as new service counselor. Click Move Details.
  3. Login as TOO. Select HHG and select approve.
  4. Login as Prime Sim. Find move code and click .
  5. Attempt to create (domestic) origin/destination SIT. An error message displays indicating domestic SIT can not be created for international shipment.
  6. Repeat step 1 and create a CONUS shipment and veriy steps 2-5.

Screenshot 2025-02-12 at 4 32 35 PM

Frontend

  • There are no aXe warnings for UI.
  • This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
  • There are no new console errors in the browser devtools.
  • There are no new console errors in the test output.
  • If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
  • This change meets the standards for Section 508 compliance.

Backend

Database

Any new migrations/schema changes:

  • Follows our guidelines for Zero-Downtime Deploys.
  • Have been communicated to #g-database.
  • Secure migrations have been tested following the instructions in our docs.

Screenshots

@MInthavongsay MInthavongsay added Scrummy Bears Scrum Team H INTEGRATION Slated for Integration Testing labels Feb 12, 2025
@MInthavongsay MInthavongsay self-assigned this Feb 12, 2025
@MInthavongsay MInthavongsay marked this pull request as ready for review February 12, 2025 21:34
@MInthavongsay MInthavongsay requested a review from a team as a code owner February 12, 2025 21:34
Copy link
Contributor

@ajlusk ajlusk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does what it claims to do
Screenshot 2025-02-14 at 3 20 25 PM
Screenshot 2025-02-14 at 3 14 50 PM

Merged integration to get a fix for something that was breaking make db_dev_fresh.

Currently failing test is a timeout, not a normal failure.

Copy link
Contributor

@CoryKleinjanCACI CoryKleinjanCACI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files changed after merging INT.

@MInthavongsay
Copy link
Contributor Author

Will close out without merge. Changeset for this PR was absorbed into #14802.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTEGRATION Slated for Integration Testing Scrummy Bears Scrum Team H
Development

Successfully merging this pull request may close these issues.

3 participants