Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picks up fixes of golang/go#18861 #290

Closed
wants to merge 1 commit into from
Closed

picks up fixes of golang/go#18861 #290

wants to merge 1 commit into from

Conversation

shawnzhu
Copy link

Problem

We've seen lots of errors from Travis worker like this:

textPayload: "time="2017-03-14T19:10:57Z" level=error msg="couldn't run script, attempting requeue" completed=false err="couldn't connect to SSH server: couldn't connect to SSH server: ssh: handshake failed: ssh: unexpected message type 3 (expected one of [6])"

the build will finally work after requeue build request several times.

I found a fix from golang/go#18861 and that fix stays on master since Feb 8.

@igorwwwwwwwwwwwwwwwwwwww
Copy link
Contributor

Nice find!

Our dependencies are managed via gvt, and vendored. So running gvt update golang.org/x/crypto/ssh to update vendor/manifest should fix this in a way that works with how we build worker.

sarahhodne added a commit that referenced this pull request Mar 15, 2017
@sarahhodne sarahhodne self-assigned this Mar 15, 2017
@sarahhodne
Copy link
Contributor

Thank you for this! Like @igorwwwwwwwwwwwwwwwwwwww mentioned, we're using gvt to manage our dependencies, so I opened a new PR that updates it there instead at #292. Closing this in favor of that PR.

@sarahhodne sarahhodne closed this Mar 15, 2017
@shawnzhu shawnzhu deleted the ssh-handshake branch March 15, 2017 13:36
sarahhodne added a commit that referenced this pull request Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants