build: update golang.org/x/crypto/ssh #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pulls in a fix for golang/go#18861. Fixes #290.
sarahhodne
requested review from
meatballhat,
Lyoness,
emdantrim and
igorwwwwwwwwwwwwwwwwwwww
This caches the vendor/manifest file as well, which means that updated dependencies won't be updated, since the cache overwrites what's in the git repo. Also, this directory only contains the downloaded files, so the speed increase wasn't as significant as I first thought. The intention was to cache the compiled files for the dependencies, not just the source code. This reverts commit 876aaf9.
|
This is the diff: golang/crypto@bed1280...728b753 |
Lyoness
approved these changes
Mar 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in a fix for golang/go#18861.
Fixes #290.