-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fw): add device authentication public key whitelist #79
Conversation
ack for the source of truth part |
There is a requirement for onboarding to work offline, so we need to have the source of truth in Suite... |
no, you need a copy of the source of truth in Suite :) |
2e9a129
to
bb6634f
Compare
specifically, what I'm proposing here is that these are the master files that are published on data.tio, and Suite grabs them from here in the same process as grabbing FW images |
yes, we should have some good automation for all those sources of truth. There are many things we should improve and we can start here. @karliatto could you check on it? a script that would check trezor-common submodule and update the respective file in connect when needed? It could be a nightl job opening PR maybe? |
Sure, having a look at that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirming that this equals the pub keys we have in Suite.
We can merge now, and we will discuss how to improve this by signing.
@mroz22 @karliatto made an issue in Suite repo: trezor/trezor-suite#12982 |
This should be the source of truth for https://github.com/trezor/trezor-suite/blob/develop/packages/connect/src/data/deviceAuthenticityConfig.ts#L48
What is missing here is any kind of signature over these files -- kind of crucial if you ask me, but there is no straightforward way to add it. We were discussing using the equivalent of Suite messaging system for it?
cc @tsusanka @komret @mroz22