-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle estimated fee error #11671
fix: handle estimated fee error #11671
Conversation
packages/suite/src/actions/wallet/send/sendFormEthereumActions.ts
Outdated
Show resolved
Hide resolved
related to #3283 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also please rebase, there were bigger changes to this file.
packages/suite/src/actions/wallet/send/sendFormEthereumActions.ts
Outdated
Show resolved
Hide resolved
packages/suite/src/actions/wallet/send/sendFormEthereumActions.ts
Outdated
Show resolved
Hide resolved
packages/suite/src/actions/wallet/send/sendFormEthereumActions.ts
Outdated
Show resolved
Hide resolved
I believe it's up to date with the develop branch, I tried to rebase it and got no conflicts whatsoever, could you please check? |
It seems that there are some conflicts in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpics
Also please reword your commits so they are like fix(suite):..., feat(suite): ... etc. |
8145595
to
9e263d3
Compare
9e263d3
to
e5f2464
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hermez-cz User gets Estimated fee error
+ reason of error. However, we set gas limit for him to some big number hardcoded in codebase.
I think user can be quite confused that he got an error but he is still able to continue. I guess we should improve the message to inform that we also set some default for him.
4f6d963
to
1eed85e
Compare
1eed85e
to
3187243
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The error coming from geth and returned the value of the error with a notification.
I have a couple of questions as I'm not sure what the expected outcome is, I'd be happy to discuss it and get some help.
Closes #3283