Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iconset replacement #12433

Closed
shenkys opened this issue May 16, 2024 · 3 comments · Fixed by #14963
Closed

Iconset replacement #12433

shenkys opened this issue May 16, 2024 · 3 comments · Fixed by #14963
Assignees
Labels
changelog User facing features that are potentionally worth mentioning in changelog QA OK Issue passed QA without any blocker UI Issues related to stylistic/aesthetic changes

Comments

@shenkys
Copy link

shenkys commented May 16, 2024

We've finally received the unified iconset where we're no longer using strokes which caused that we had to keep 5 different variants of each icon. Now we're using scalable stroke so no matter at what size you export it, it'll look consistently throughout.

What we’ll need to do (likely) is to replace all the icons in the repo with new ones. I’d just need someone to check:

  • If the naming convention is the same
  • If we’re missing any icons
  • If some icons aren’t matching
  • Replace it in repo

Outline.zip
source: https://www.figma.com/design/BdbvEYgjDdntL3haFcXRgV/%5BAssets%5D-Icons?node-id=1746-54&node-type=SECTION&t=u59DUGSGadXCIoTQ-11

@shenkys shenkys moved this to 🎯 To do in Suite Mobile May 16, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop May 16, 2024
@shenkys shenkys self-assigned this May 16, 2024
@shenkys shenkys moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile May 16, 2024
@mnuky mnuky moved this from 🏃‍♀️ In progress to 🎯 To do in Suite Mobile May 17, 2024
@mnuky mnuky added low hanging fruit Simple, quick task. Doable in 2 hours. mobile Suite Lite issues and PRs labels May 22, 2024
@matejkriz matejkriz removed the low hanging fruit Simple, quick task. Doable in 2 hours. label Jun 24, 2024
@matejkriz
Copy link
Member

It is a small and "easy" task, but not low hanging - testing can be time consuming (not days, but more than 2 hours...)

@mnuky mnuky added the low hanging fruit Simple, quick task. Doable in 2 hours. label Jul 22, 2024
@matejkriz matejkriz removed the low hanging fruit Simple, quick task. Doable in 2 hours. label Jul 24, 2024
@mnuky mnuky added the good first issue Issue for newbie developers who want to participate label Jul 25, 2024
@matejkriz matejkriz removed the mobile Suite Lite issues and PRs label Aug 30, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Suite Desktop Aug 30, 2024
@matejkriz matejkriz added UI Issues related to stylistic/aesthetic changes and removed good first issue Issue for newbie developers who want to participate labels Aug 30, 2024
@matejkriz matejkriz removed this from Suite Mobile Sep 2, 2024
@matejkriz matejkriz removed this from Suite Desktop Sep 2, 2024
@matejkriz matejkriz moved this to 🎯 To do in Suite Mobile Sep 2, 2024
@matejkriz
Copy link
Member

tech notes:

  • current icons package will be renamed to @suite-common/icons-deprecated and the new iconset will go to new package with current name.
  • There will be two variants for every icon - outlined and filled (marked in name of icon by the suffix)
  • Both platform can shift to the new iconset independently
  • We need to find a way how to ideally not include all the icons in the bundle but only those used. But that tooling should not be part of the shared package.
  • Components like CryptoIcon, FlagIcon, Icon, should not be part of the new shared iconset anymore - the shared package should not depend on react-native at all.

@matejkriz matejkriz added the changelog User facing features that are potentionally worth mentioning in changelog label Nov 5, 2024
@STew790
Copy link
Contributor

STew790 commented Nov 12, 2024

QA OK
I haven't found any missing/broken icons throughout testing but will definitely monitor this.

Info
24.11.1 35433e7

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Nov 12, 2024
@STew790 STew790 added the QA OK Issue passed QA without any blocker label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog User facing features that are potentionally worth mentioning in changelog QA OK Issue passed QA without any blocker UI Issues related to stylistic/aesthetic changes
Projects
Status: ✅ Approved
Development

Successfully merging a pull request may close this issue.

5 participants