Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sporadic missing icons in dark mode #14311

Closed
sime opened this issue Sep 12, 2024 · 2 comments · Fixed by #14963
Closed

Sporadic missing icons in dark mode #14311

sime opened this issue Sep 12, 2024 · 2 comments · Fixed by #14963
Labels
bug Something isn't working as expected mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker

Comments

@sime
Copy link
Contributor

sime commented Sep 12, 2024

Missing icons appear sporadically, so far, only noticed in dark mode. Artifact is resolved when navigating to another screen and navigating back.

image
image
@sime sime added the mobile Suite Lite issues and PRs label Sep 12, 2024
@sime sime added the bug Something isn't working as expected label Sep 12, 2024
@matejkriz
Copy link
Member

Let's fix this together with #12433, we will probably switch from Skia to react-native-svg or icon font.

@matejkriz matejkriz moved this to 🎯 To do in Suite Mobile Sep 13, 2024
@matejkriz matejkriz mentioned this issue Oct 21, 2024
Merged
@matejkriz matejkriz moved this from 🎯 To do to 🤝 Needs QA in Suite Mobile Nov 4, 2024
@STew790
Copy link
Contributor

STew790 commented Nov 11, 2024 •
edited
Loading

QA OK
I haven't seen any missing icons in dark mode for weeks now.
Info
24.11.1 ff16b78

@STew790 STew790 moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Nov 11, 2024
@STew790 STew790 added the QA OK Issue passed QA without any blocker label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected mobile Suite Lite issues and PRs QA OK Issue passed QA without any blocker
Projects
Suite Mobile
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(mobile): new icons trezor/trezor-suite
3 participants
@sime @matejkriz @STew790