-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mobile): new icons #14963
feat(mobile): new icons #14963
Conversation
9cfbaaa
to
617a7a3
Compare
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
617a7a3
to
ac8ca0f
Compare
@SocketSecurity ignore npm/[email protected] |
|
e40ec9f
to
e2886e2
Compare
suite-native/icons/src/Icon.tsx
Outdated
color?: IconColor; | ||
}; | ||
|
||
export const Icon = ({ name, size = 'large', color = 'iconDefault' }: IconProps) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not able to reproduce this one, can you please try again? Maybe it was some random temp issue.
I guess this can fix also |
Yes it should fix all icon related issue we have now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't go through the individual icon changes, I mostly check only the first commit and it works nice, including switching between dark and light mode 🎉
Only issue I found out is the cut off buttons in the Device switcher.
It would be great to update README of @suite-common/icons too, but it can be a followup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the icon for Safe 3 is broken only in the font generated from correct SVG, so maybe there are more icons broken, only not so obvious?
b7718a7
to
9820e56
Compare
9820e56
to
5b31801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
* feat(mobile): new mobile icons package + icon font * chore: replace deprecated icons in mobile app * fix: fix broken icons and add README
I recommend check this commit by commit, first one is creating new mobile icons package and some refactoring. Second one is just replacing deprecated package with new one.
Description
This new icons package is created with main focus on performance and minimal performance overhead so it should be super fast. I also did some refactoring and simplification of some
Button
components which also helped with performance little bit.Related Issue
Resolve #12433
Fixes #11596
Fixes #14311
Screenshots: