fix(connect-popup): update text in selectAccount #12340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
reviewed
May 10, 2024
| @@ -670,16 +670,12 @@ <h3></h3> | |||
| <div class="select-account p2wpkh"> | |||
| <div> | |||
| <div class="tabs"> | |||
| <div data-tab="p2wpkh" class="tab-selection p2wpkh">Accounts</div> | |||
| <div data-tab="p2wpkh" class="tab-selection p2wpkh">Default accounts</div> | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
"Default accounts (SegWit)" seems fine. 👍🏻
Don't know from the top of my head how we handle SegWit/Segwit in Suite. Please use whatever is in Suite.
There was a problem hiding this comment.
I'm using the same label as in Suite which doesn't say SegWit, but maybe it's better to mention it
There was a problem hiding this comment.
Here is a different environment for the users, so let's mention it.
There was a problem hiding this comment.
However I was talking about whether we use SegWit (big "W") or Segwit (small "w").
There was a problem hiding this comment.
I think big W is standard
martykan
force-pushed
the
fix/connect-popup-selectaccount-update
branch
2 times, most recently
from
d4f35b1 to
fcbb434
Compare
martykan
force-pushed
the
fix/connect-popup-selectaccount-update
branch
from
11e7c34 to
5b36bae
Compare
martykan
force-pushed
the
fix/connect-popup-selectaccount-update
branch
from
5b36bae to
030fe8b
Compare
Hannsek
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename account types to be the same as in Suite:
Removed warning about support in Trezor Wallet
Screenshots