Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connect-popup): update text in selectAccount #12340

Merged
merged 1 commit into from
May 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions packages/connect-popup/src/static/popup.html
Original file line number Diff line number Diff line change
Expand Up @@ -670,16 +670,14 @@ <h3></h3>
<div class="select-account p2wpkh">
<div>
<div class="tabs">
<div data-tab="p2wpkh" class="tab-selection p2wpkh">Accounts</div>
<div data-tab="p2wpkh" class="tab-selection p2wpkh">
Default accounts (SegWit)
</div>
<div data-tab="p2tr" class="tab-selection p2tr">Taproot accounts</div>
<div data-tab="p2sh" class="tab-selection p2sh">Segwit accounts</div>
<div data-tab="p2sh" class="tab-selection p2sh">Legacy SegWit accounts</div>
<div data-tab="p2pkh" class="tab-selection p2pkh">Legacy accounts</div>
</div>
<h3>Select <span>#COIN</span> account</h3>
<div class="bech32-warning" style="display: none">
This Account type is supported only in Trezor Suite.<br />
Pick "Segwit account" if you need to use it in Trezor Wallet.
</div>
</div>
<div class="wrapper">
<div class="select-account-list p2wpkh">
Expand Down
4 changes: 0 additions & 4 deletions packages/connect-popup/src/view/selectAccount.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ export const selectAccount = (payload: UiRequestSelectAccount['payload']) => {
const selectedType =
defaultAccountType || (accountTypes.includes('p2sh') ? 'p2sh' : 'p2wpkh');
selectAccountContainer.className = `select-account ${selectedType}`;
if (accountTypes.includes('p2sh')) {
const bech32warn = container.getElementsByClassName('bech32-warning')[0];
bech32warn.removeAttribute('style'); // remove default 'display: none' from element
}
for (let i = 0; i < buttons.length; i++) {
const button = buttons[i];
const type = button.getAttribute('data-tab');
Expand Down
Loading